[mod] death to silent unverbose errors èwé

This commit is contained in:
Laurent Peuch 2019-07-20 16:03:30 +02:00
parent c1ae0dd46c
commit 9c6c92b2c1

View file

@ -93,8 +93,8 @@ class BaseAuthenticator(object):
try:
# Extract id and hash from token
s_id, s_hash = token
except TypeError:
logger.error("unable to extract token parts from '%s'", token)
except TypeError as e:
logger.error("unable to extract token parts from '%s' because '%s'", token, e)
if password is None:
raise MoulinetteError('error_see_log')
@ -110,17 +110,19 @@ class BaseAuthenticator(object):
self.authenticate(password)
except MoulinetteError:
raise
except:
logger.exception("authentication (name: '%s', vendor: '%s') fails",
self.name, self.vendor)
except Exception as e:
logger.exception("authentication (name: '%s', vendor: '%s') fails because '%s'",
self.name, self.vendor, e)
raise MoulinetteError('unable_authenticate')
# Store session
if store_session:
try:
self._store_session(s_id, s_hash, password)
except:
logger.exception("unable to store session")
except Exception as e:
import traceback
traceback.print_exc()
logger.exception("unable to store session because %s", e)
else:
logger.debug("session has been stored")