Use flake8 under Tox and fix complaints

.travis.yml

@@ -1,7 +1,14 @@
 language: python
-install: pip install tox pep8
+
-python:
+matrix:
-    - 2.7
+  include:
+    - python: 2.7
+      env: TOXENV=py27
+    - python: 2.7
+      env: TOXENV=lint
+
+install:
+  - pip install tox
+
 script:
-  - pep8 moulinette
   - tox

README.md

@@ -55,3 +55,11 @@ Requirements
 * python-gnupg (>= 0.3)
 * python-ldap (>= 2.4)
 * PyYAML
+
+Testing
+-------
+
+```
+$ pip install tox
+$ tox
+```

moulinette/interfaces/__init__.py

@@ -645,7 +645,7 @@ class PositionalsFirstHelpFormatter(argparse.HelpFormatter):
 
     def _format_usage(self, usage, actions, groups, prefix):
         if prefix is None:
-                # TWEAK : not using gettext here...
+            # TWEAK : not using gettext here...
             prefix = 'usage: '
 
         # if usage is specified, use that

moulinette/interfaces/api.py

@@ -11,7 +11,7 @@ from gevent.queue import Queue
 from geventwebsocket import WebSocketError
 
 from bottle import run, request, response, Bottle, HTTPResponse
-from bottle import get, post, install, abort, delete, put
+from bottle import abort
 
 from moulinette import msignals, m18n, DATA_DIR
 from moulinette.core import MoulinetteError, clean_session

moulinette/interfaces/cli.py

@@ -7,7 +7,6 @@ import locale
 import logging
 from argparse import SUPPRESS
 from collections import OrderedDict
-import time
 import pytz
 from datetime import date, datetime
 

moulinette/utils/log.py

@@ -3,7 +3,7 @@ import logging
 
 # import all constants because other modules try to import them from this
 # module because SUCCESS is defined in this module
-from logging import (addLevelName, setLoggerClass, Logger, getLogger, NOTSET,
+from logging import (addLevelName, setLoggerClass, Logger, getLogger, NOTSET,  # noqa
                      DEBUG, INFO, WARNING, ERROR, CRITICAL)
 
 

setup.cfg

@@ -1,2 +1,2 @@
-[pep8]
+[flake8]
-ignore = E501,E128,E731
+ignore = E501,E128,E731,E722

tox.ini

@@ -1,5 +1,7 @@
 [tox]
-envlist = py27
+envlist = 
+  py27
+  lint
 skipdist = True
 isolated_build = True
 
@@ -15,3 +17,9 @@ deps =
   requests-mock >= 1.6.0, < 2.0
 commands =
     pytest {posargs}
+
+[testenv:lint]
+commands = flake8 moulinette test
+deps = flake8
+skip_install = True
+usedevelop = False