From 22d703cb4805d1e7037f6189c11624d00bc2c2de Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Sun, 1 Sep 2024 17:55:26 +0200
Subject: [PATCH] bash syntax check: gotta return 0 for the job to be flagged
 as failure

---
 lib/tests.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/tests.sh b/lib/tests.sh
index a7c0f83..53861d4 100644
--- a/lib/tests.sh
+++ b/lib/tests.sh
@@ -32,7 +32,9 @@ _STUFF_TO_RUN_BEFORE_INITIAL_SNAPSHOT() {
         log_report_test_success
     else
         echo "{'level': 0}" >$result_json
-        log_critical "Obvious syntax issues found which will make the scripts crash ... not running the actual tests until these are fixed"
+        log_error "Obvious syntax issues found which will make the scripts crash ... not running the actual tests until these are fixed"
+        # Return 0 instead of 1 such that the job gets flagged as failure and not as error
+        return 0
     fi
 
     # We filter apt deps starting with $app_id to prevent stupid issues with for example cockpit and transmission where the apt package is not properly reinstalled on reinstall-after-remove test ...