YunoHost/package_check
1
0
Fork 0
mirror of https://github.com/YunoHost/package_check.git synced 2024-09-03 20:06:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Complain about 'config file manually modified' thing in summary.png and for level 7

Browse source
This commit is contained in:
Alexandre Aubin 2023-02-14 18:11:23 +01:00
parent efc9313f87
commit e0c4766168
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/analyze_test_results.py
View file

@ -43,6 +43,9 @@ def test_notes(test):
if test['results'].get("install_dir_permissions"):
yield '<style=danger>Unsafe install dir permissions</style>'
if test['results'].get("file_manually_modified"):
yield '<style=danger>Config file overwritten / manually modified</style>'
levels = []
@ -161,6 +164,7 @@ def level_7(tests):
unsafe_install_dir_perms = any(t["results"].get("install_dir_permissions") for t in tests_on_which_to_check_for_runtime_warnings)
alias_traversal = any(t["results"].get("alias_traversal") for t in tests_on_which_to_check_for_runtime_warnings)
witness = any(t["results"].get("witness") for t in tests_on_which_to_check_for_runtime_warnings)
file_manually_modified = any(t["results"].get("file_manually_modified") for t in tests_on_which_to_check_for_runtime_warnings)
return all(t["results"]["main_result"] == "success" for t in tests) \
and linter_tests != [] \
@ -168,6 +172,7 @@ def level_7(tests):
and not alias_traversal \
and not too_many_warnings \
and not unsafe_install_dir_perms \
and not file_manually_modified \
and "App.qualify_for_level_7" in linter_tests[0]["results"]["success"]

10
lib/tests_coordination.sh
View file

@ -132,7 +132,15 @@ TEST_LAUNCHER () {
# which should not happen during tests because no human modified the file ...
if grep -q --extended-regexp 'has been manually modified since the installation or last upgrade. So it has been duplicated' $current_test_log
then
log_error "Apparently the log is telling that 'some file got manually modified' ... which should not happen, considering that no human modified the file ... ! Maybe you need to check what's happening with ynh_store_file_checksum and ynh_backup_if_checksum_is_different between install and upgrade."
log_error "Apparently the log is telling that 'some file got manually modified' ... which should not happen, considering that no human modified the file ... ! This is usually symptomatic of something that modified a conf file after installing it with ynh_add_config. Maybe usigin ynh_store_file_checksum can help, or maybe the issue is more subtle!"
if [[ "$test_type" == "TEST_UPGRADE" ]] && [[ "$test_arg" == "" ]]
then
SET_RESULT "failure" file_manually_modified
fi
if [[ "$test_type" == "TEST_BACKUP_RESTORE" ]]
then
SET_RESULT "failure" file_manually_modified
fi
fi
# Check that the number of warning ain't higher than a treshold