From c67813f5d5046f6b159e5f9b6041ce47be9ed566 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Sat, 13 Jun 2020 20:54:05 +0200 Subject: [PATCH 1/2] add specific count of progression indicator for backup --- sub_scripts/testing_process.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sub_scripts/testing_process.sh b/sub_scripts/testing_process.sh index f154a2a..eae5045 100644 --- a/sub_scripts/testing_process.sh +++ b/sub_scripts/testing_process.sh @@ -194,7 +194,7 @@ CHECK_TEMPLATE () { if [ -e "$app_scripts_dir/$script" ] && [ "$script" != "config" ] then template_output="$($grep_command --count "ynh_script_progression|ynh_print_info" "$app_scripts_dir/$script")" - if [ $template_output -lt 5 ] || ( [ "$script" = "change_url" ] && [ $template_output -lt 3 ] ) + if [ $template_output -lt 5 ] || ( [ "$script" = "change_url" ] && [ $template_output -lt 3 ] || ( [ "$script" = "backup" ] && [ $template_output -lt 4 ] ) then template_output="$app_scripts_dir/$script" show_error "Looks like there isn't many comment progression indicators in your script" "Consider adding more indicators to help your users know the progression of the scripts" From a0ae79402dd86d5c45bf35919cb6496950a7afde Mon Sep 17 00:00:00 2001 From: yalh76 Date: Tue, 16 Jun 2020 00:44:26 +0200 Subject: [PATCH 2/2] missing parenthesis --- sub_scripts/testing_process.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sub_scripts/testing_process.sh b/sub_scripts/testing_process.sh index eae5045..dd9bc2c 100644 --- a/sub_scripts/testing_process.sh +++ b/sub_scripts/testing_process.sh @@ -194,7 +194,7 @@ CHECK_TEMPLATE () { if [ -e "$app_scripts_dir/$script" ] && [ "$script" != "config" ] then template_output="$($grep_command --count "ynh_script_progression|ynh_print_info" "$app_scripts_dir/$script")" - if [ $template_output -lt 5 ] || ( [ "$script" = "change_url" ] && [ $template_output -lt 3 ] || ( [ "$script" = "backup" ] && [ $template_output -lt 4 ] ) + if [ $template_output -lt 5 ] || ( [ "$script" = "change_url" ] && [ $template_output -lt 3 ] ) || ( [ "$script" = "backup" ] && [ $template_output -lt 4 ] ) then template_output="$app_scripts_dir/$script" show_error "Looks like there isn't many comment progression indicators in your script" "Consider adding more indicators to help your users know the progression of the scripts"