From f1ede681b07a620c3d37d22ee41825d757f3d234 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Thu, 2 Dec 2021 15:25:16 +0100 Subject: [PATCH] Fix linter error not properly being caught by level 5 definition --- lib/analyze_test_results.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/analyze_test_results.py b/lib/analyze_test_results.py index ef5ae91..499b998 100644 --- a/lib/analyze_test_results.py +++ b/lib/analyze_test_results.py @@ -130,7 +130,7 @@ def level_5(tests): return not alias_traversal_detected \ and linter_tests != [] \ - and linter_tests[0]["results"]["main_result"] == "success" + and linter_tests[0]["results"]["error"] == [] @level(6, "App is in a community-operated git org") @@ -154,7 +154,7 @@ def level_7(tests): """ linter_tests = [t for t in tests if t["test_type"] == "PACKAGE_LINTER"] - + # For runtime warnings, ignore stuff happening during upgrades from previous versions tests_on_which_to_check_for_runtime_warnings = [t for t in tests if not (t["test_type"] == "TEST_UPGRADE" and t["test_arg"])] too_many_warnings = any(t["results"].get("too_many_warnings") for t in tests_on_which_to_check_for_runtime_warnings)