YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Improve text and code style

Browse source
This commit is contained in:
Jean-Baptiste Holcroft 2018-05-27 12:01:38 +02:00
parent 834ac35b96
commit 0d18196949
1 changed files with 10 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
package_linter.py
View file

@ -360,27 +360,23 @@ def check_arg_retrieval(script):
def check_helper_usage_dependencies(script_name): def check_helper_usage_dependencies(script_name):
""" """
detects usage of ynh_package_* & apt-get * and suggest usage of Detect usage of ynh_package_* & apt-get *
ynh_remove_app_dependencies and ynh_remove_app_dependencies and suggest herlpers ynh_install_app_dependencies and ynh_remove_app_dependencies
""" """
script = open(script_name).read() script = open(script_name).read()
present = False if "ynh_package_install" in script or "apt-get install" in script:
print_warning("You should not use `ynh_package_install` or `apt-get install`, use `ynh_install_app_dependencies` instead")
present = "ynh_package_install" in script or "apt-get install" in script if "ynh_package_remove" in script or "apt-get remove" in script:
print_warning("You should not use `ynh_package_remove` or `apt-get removeè, use `ynh_remove_app_dependencies` instead")
if present:
print_warning("You should not use ynh_package_install or apt-get install, use ynh_install_app_dependencies instead")
present = False
present = "ynh_package_remove" in script or "apt-get remove" in script
if present:
print_warning("You should not use ynh_package_remove or apt-get remove, use ynh_remove_app_dependencies instead")
def check_helper_usage_unix(script_name): def check_helper_usage_unix(script_name):
""" """
detects usage of sudo, rm and sed Detect usage of unix commands with helper equivalents:
- sudo → nothing
- rm → ynh_secure_remove
- sed -i → ynh_replace_string
""" """
script = open(script_name).read() script = open(script_name).read()