YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #27 from YunoHost/return_value

Browse source 
Return value
This commit is contained in:
M5oul 2017-04-11 10:17:12 +02:00 committed by GitHub
commit 2633503658
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
package_linter.py
View file

@ -37,18 +37,20 @@ def print_wrong(str):
def check_files_exist(app_path): def check_files_exist(app_path):
""" """
Check files exist Check files exist
'backup' and 'restore' scripts are mandatory
""" """
return_code = 0 return_code = 0
print (c.BOLD + c.HEADER + ">>>> MISSING FILES <<<<" + c.END) print(c.BOLD + c.HEADER + ">>>> MISSING FILES <<<<" + c.END)
fnames = ("manifest.json", "scripts/install", "scripts/remove", fnames = ("manifest.json", "scripts/install", "scripts/remove",
"scripts/upgrade", "scripts/backup", "scripts/restore", "LICENSE", "README.md") "scripts/upgrade", "scripts/backup", "scripts/restore", "LICENSE", "README.md")
for fname in fnames: for nbr, fname in enumerate(fnames):
if check_file_exist(app_path + "/" + fname): if check_file_exist(app_path + "/" + fname):
print_right(fname) print_right(fname)
else: else:
print_wrong(fname) print_wrong(fname)
if nbr != 4 and nbr != 5:
return_code = 1 return_code = 1
return return_code return return_code
@ -66,7 +68,7 @@ def read_file(file_path):
def check_source_management(app_path): def check_source_management(app_path):
print (c.BOLD + c.HEADER + "\n>>>> SOURCES MANAGEMENT <<<<" + c.END) print(c.BOLD + c.HEADER + "\n>>>> SOURCES MANAGEMENT <<<<" + c.END)
DIR = os.path.join(app_path, "sources") DIR = os.path.join(app_path, "sources")
# Check if there is more than six files on 'sources' folder # Check if there is more than six files on 'sources' folder
if os.path.exists(os.path.join(app_path, "sources")) and \ if os.path.exists(os.path.join(app_path, "sources")) and \
@ -79,7 +81,7 @@ def check_source_management(app_path):
def check_manifest(manifest): def check_manifest(manifest):
print (c.BOLD + c.HEADER + "\n>>>> MANIFEST <<<<" + c.END) print(c.BOLD + c.HEADER + "\n>>>> MANIFEST <<<<" + c.END)
""" """
Check if there is no comma syntax issue Check if there is no comma syntax issue
""" """
@ -176,14 +178,14 @@ def check_script(path, script_name, script_nbr):
if check_file_exist(script_path) == 0: if check_file_exist(script_path) == 0:
return return
print (c.BOLD + c.HEADER + "\n>>>>", print(c.BOLD + c.HEADER + "\n>>>>",
script_name.upper(), "SCRIPT <<<<" + c.END) script_name.upper(), "SCRIPT <<<<" + c.END)
script = read_file(script_path) script = read_file(script_path)
return_code = check_non_helpers_usage(script) or return_code return_code = check_non_helpers_usage(script) or return_code
if script_nbr < 5: if script_nbr < 5:
return_code = check_verifications_done_before_modifying_system(script) or return_code check_verifications_done_before_modifying_system(script)
return_code = check_set_usage(script_name, script) or return_code return_code = check_set_usage(script_name, script) or return_code
check_arg_retrieval(script) check_arg_retrieval(script)
@ -223,6 +225,7 @@ def check_verifications_done_before_modifying_system(script):
"Verifications (with 'ynh_die' or 'exit' commands) are done before any system modification.") "Verifications (with 'ynh_die' or 'exit' commands) are done before any system modification.")
return 0 return 0
def check_non_helpers_usage(script): def check_non_helpers_usage(script):
""" """
check if deprecated commands are used and propose helpers: check if deprecated commands are used and propose helpers:
@ -297,7 +300,7 @@ def check_arg_retrieval(script):
if line_nbr > 30: if line_nbr > 30:
exitFlag = True exitFlag = True
break break
if exitFlag == True: if exitFlag is True:
break break
if present: if present: