check_files_exist -> misc_file_checks and other tweaks

This commit is contained in:
Alexandre Aubin 2019-03-02 01:30:58 +01:00
parent b089229482
commit 26c383d0b3

View file

@ -93,13 +93,14 @@ class App():
self.scripts = { f: Script(self.path, f) for f in scripts }
def check_files_exist(app_path):
"""
Check files exist
'backup' and 'restore' scripts are not mandatory
"""
def misc_file_checks(app_path):
print_header("MISC FILE CHECKS")
#
# Check for recommended and mandatory files
#
print_header("MISSING FILES")
filenames = ("manifest.json", "LICENSE", "README.md",
"scripts/install", "scripts/remove",
"scripts/upgrade",
@ -110,14 +111,21 @@ def check_files_exist(app_path):
if file_exists(app_path + "/" + filename):
continue
elif filename in non_mandatory:
print_warning(filename)
print_warning("Consider adding a file %s" % filename)
else:
print_error(filename)
print_error("File %s is mandatory" % filename)
#
# Deprecated php-fpm.ini thing
#
if file_exists(app_path + "/conf/php-fpm.ini"):
print_warning("Using a separate php-fpm.ini file is deprecated. Please merge your php-fpm directives directly in the pool file. (c.f. https://github.com/YunoHost-Apps/nextcloud_ynh/issues/138 )")
#
# Deprecated usage of 'add_header' in nginx conf
#
for filename in os.listdir(app_path + "/conf"):
if not os.path.isfile(filename):
continue
@ -465,7 +473,7 @@ def main():
# Global checks
app = App(app_path)
check_files_exist(app_path)
misc_file_checks(app_path)
check_source_management(app_path)
check_manifest(app_path)