From 3898d6ab1faf9a1d4e5dc4b60bee1b047ad0aa73 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sun, 8 Jan 2023 15:26:32 +0100 Subject: [PATCH] Rework maintenance check because the info is now in the 'antifeatures' key in the catalog. Also refuse level 8 for apps flagged as deprecated, alpha or replaced by another app --- package_linter.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package_linter.py b/package_linter.py index b117fed..4f11c3b 100755 --- a/package_linter.py +++ b/package_linter.py @@ -487,9 +487,10 @@ class App(TestSuite): # Level 8 = qualifies for level 7 + maintained + long term good quality catalog_infos = self.app_catalog.catalog_infos - is_maintained = catalog_infos and catalog_infos.get("maintained", True) is True - if not is_maintained: - _print(" The app is flagged as not maintained in the app catalog") + antifeatures = catalog_infos and catalog_infos.get("antifeatures", []) + + if any(af in antifeatures for af in ['package-not-maintained', 'deprecated-software', 'alpha-software', 'replaced-by-another-app']): + _print(" In the catalog, the app is flagged as not maintained / deprecated / alpha or replaced by another app") elif ( "qualify_for_level_7" in successes and "is_long_term_good_quality" in successes