YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

[enh] Check fail if rm -rf

Browse source
This commit is contained in:
ljf (zamentur) 2018-12-13 22:48:49 +01:00 committed by GitHub
parent 132ee456e0
commit 48075f80e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
package_linter.py
View file

@ -381,14 +381,14 @@ def check_helper_usage_unix(path, script_name):
""" """
script = read_file(path) script = read_file(path)
if "rm -rf" in script: if "rm -rf" in script or "rm -Rf" in script:
print_warning("You should avoid using `rm -rf`, please use `ynh_secure_remove` instead") print_wrong("[YEP-2.12] You should avoid using `rm -rf`, please use `ynh_secure_remove` instead")
if "sed -i" in script: if "sed -i" in script:
print_warning("You should avoid using `sed -i`, please use `ynh_replace_string` instead") print_warning("[YEP-2.12] You should avoid using `sed -i`, please use `ynh_replace_string` instead")
if "sudo " in script: if "sudo " in script:
print_warning("You should not need to use `sudo`, the script is being run as root. (If you need to run a command using a specific user, use `ynh_exec_as`)") print_warning("[YEP-2.12] You should not need to use `sudo`, the script is being run as root. (If you need to run a command using a specific user, use `ynh_exec_as`)")
def check_helper_consistency(path, script_name): def check_helper_consistency(path, script_name):
""" """