YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use read_file() to get file content without comments

Browse source
This commit is contained in:
Alexandre Aubin 2018-12-02 17:56:45 +01:00
parent 21cb506419
commit 4a68c76089
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
package_linter.py
View file

@ -364,7 +364,7 @@ def check_helper_usage_dependencies(script_name):
Detect usage of ynh_package_* & apt-get *
and suggest herlpers ynh_install_app_dependencies and ynh_remove_app_dependencies
"""
script = open(script_name).read()
script = read_file(script_name)
if "ynh_package_install" in script or "apt-get install" in script:
print_warning("You should not use `ynh_package_install` or `apt-get install`, use `ynh_install_app_dependencies` instead")
@ -379,7 +379,7 @@ def check_helper_usage_unix(script_name):
- rm → ynh_secure_remove
- sed -i → ynh_replace_string
"""
script = open(script_name).read()
script = read_file(script_name)
if "rm -rf" in script:
print_warning("You should not use `rm -rf`, use ynh_secure_remove instead")
@ -395,7 +395,7 @@ def check_helper_consistency(path, script_name, script_path):
check if ynh_install_app_dependencies is present in install/upgrade/restore
so dependencies are up to date after restoration or upgrade
"""
script = open(script_path).read()
script = read_file(script_name)
if script_name == "install" and "ynh_install_app_dependencies" in script:
for name in ["upgrade", "restore"]: