YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Report app using a folder in /home that aint the recommended practice /home/yunohost.app/ or multimedia

Browse source
This commit is contained in:
Alexandre Aubin 2021-03-11 02:59:34 +01:00
parent abf751cd61
commit 4effddeab1
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
package_linter.py
View file

@ -581,6 +581,16 @@ class App(TestSuite):
if os.system("grep -q -nr '/etc/ssowat/conf.json.persistent' %s/*/* 2>/dev/null" % self.path) == 0: if os.system("grep -q -nr '/etc/ssowat/conf.json.persistent' %s/*/* 2>/dev/null" % self.path) == 0:
yield Error("Don't do black magic with /etc/ssowat/conf.json.persistent !") yield Error("Don't do black magic with /etc/ssowat/conf.json.persistent !")
@test()
def app_data_in_unofficial_dir(self):
allowed_locations = ["yunohost.app", "yunohost.conf", "yunohost.backup", "yunohost.multimedia"]
cmd = "grep -IhEro '/home/yunohost[^/ ]*/' %s/scripts || true" % self.path
home_locations = subprocess.check_output(cmd, shell=True).decode('utf-8').strip().split("\n")
forbidden_locations = set([location for location in home_locations if location and location not in allowed_locations])
if forbidden_locations:
yield Warning("The app seems to be storing data in the 'forbidden' locations %s. The recommended pratice is rather to store data in /home/yunohost.app/$app or /home/yunohost.multimedia (depending on the use case)" % ', '.join(forbidden_locations))
class Configurations(TestSuite): class Configurations(TestSuite):