YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Requalify some 'info' as 'warning' now that they integrated by the vast majority of good quality apps

Browse source
This commit is contained in:
Alexandre Aubin 2021-05-10 19:52:40 +02:00
parent 5b455de1bd
commit 5b0371c46d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
package_linter.py
View file

@ -579,7 +579,7 @@ class App(TestSuite):
yield Warning("Found some inconsistencies in the 'yunohost service add' commands between install, upgrade and restore:\n%s" % details) yield Warning("Found some inconsistencies in the 'yunohost service add' commands between install, upgrade and restore:\n%s" % details)
if found_legacy_logtype_option: if found_legacy_logtype_option:
yield Info("Using option '--log_type systemd' with 'yunohost service add' is not relevant anymore") yield Warning("Using option '--log_type systemd' with 'yunohost service add' is not relevant anymore")
if occurences["install"] and not app.scripts["remove"].contains("yunohost service remove"): if occurences["install"] and not app.scripts["remove"].contains("yunohost service remove"):
yield Error( yield Error(
@ -651,7 +651,7 @@ class Configurations(TestSuite):
yield Error("Do not force Level 5=1 in check_process...") yield Error("Do not force Level 5=1 in check_process...")
if os.system("grep -q ' *Level [^5]=' '%s'" % check_process_file) == 0: if os.system("grep -q ' *Level [^5]=' '%s'" % check_process_file) == 0:
yield Info("Setting Level x=y in check_process is obsolete / not relevant anymore") yield Warning("Setting Level x=y in check_process is obsolete / not relevant anymore")
@test() @test()
def check_process_consistency(self): def check_process_consistency(self):
@ -726,7 +726,7 @@ class Configurations(TestSuite):
return return
if "SOURCE_SUM_PRG=md5sum" in content: if "SOURCE_SUM_PRG=md5sum" in content:
yield Info("%s: Using md5sum checksum is not so great for " yield Warning("%s: Using md5sum checksum is not so great for "
"security. Consider using sha256sum instead." % filename) "security. Consider using sha256sum instead." % filename)
@ -1548,7 +1548,7 @@ class Script(TestSuite):
@test() @test()
def sudo(self): def sudo(self):
if self.containsregex(r"sudo \w"): # \w is here to not match sudo -u, legit use because ynh_exec_as not official yet... if self.containsregex(r"sudo \w"): # \w is here to not match sudo -u, legit use because ynh_exec_as not official yet...
yield Info( yield Warning(
"You should not need to use 'sudo', the script is being run as root. " "You should not need to use 'sudo', the script is being run as root. "
"(If you need to run a command using a specific user, use 'ynh_exec_as' (or 'sudo -u'))" "(If you need to run a command using a specific user, use 'ynh_exec_as' (or 'sudo -u'))"
) )
@ -1579,7 +1579,7 @@ class Script(TestSuite):
@test(only=["backup"]) @test(only=["backup"])
def progression_in_backup(self): def progression_in_backup(self):
if self.contains("ynh_script_progression"): if self.contains("ynh_script_progression"):
yield Info( yield Warning(
"We recommend to *not* use 'ynh_script_progression' in backup " "We recommend to *not* use 'ynh_script_progression' in backup "
"scripts because no actual work happens when running the script " "scripts because no actual work happens when running the script "
" : YunoHost only fetches the list of things to backup (apart " " : YunoHost only fetches the list of things to backup (apart "