YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Report missing ask strings in install questions

Browse source
This commit is contained in:
Alexandre Aubin 2021-09-29 15:22:43 +02:00
parent 8d9d3afc62
commit 5b6cde0562
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
package_linter.py
View file

@ -1140,7 +1140,7 @@ class Manifest(TestSuite):
) )
@test() @test()
def obsolete_ask_strings(self): def obsolete_or_missing_ask_strings(self):
ask_string_managed_by_the_core = [("domain", "domain"), ("path", "path"), ("admin", "user"), ("is_public", "boolean"), ("password", "password")] ask_string_managed_by_the_core = [("domain", "domain"), ("path", "path"), ("admin", "user"), ("is_public", "boolean"), ("password", "password")]
@ -1149,6 +1149,8 @@ class Manifest(TestSuite):
if argument.get("ask") and (argument.get("name"), argument.get("type")) in ask_string_managed_by_the_core: if argument.get("ask") and (argument.get("name"), argument.get("type")) in ask_string_managed_by_the_core:
yield Info("'ask' string for argument %s is superfluous / will be ignored. Since 4.1, the core handles the 'ask' string for some recurring arg name/type for consistency and easier i18n. See https://github.com/YunoHost/example_ynh/pull/142" % argument.get("name")) yield Info("'ask' string for argument %s is superfluous / will be ignored. Since 4.1, the core handles the 'ask' string for some recurring arg name/type for consistency and easier i18n. See https://github.com/YunoHost/example_ynh/pull/142" % argument.get("name"))
elif not argument.get("ask") and (argument.get("name"), argument.get("type")) not in ask_string_managed_by_the_core:
yield Warning("You should add 'ask' strings for argument %s" % argument.get("name"))
@test() @test()
def is_public_help(self): def is_public_help(self):