From 652d6bacb33254ef5ed18156ed71ff2d8b4194c1 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 17:52:08 +0100 Subject: [PATCH] Encourage packagers to detail what is_public means --- package_linter.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/package_linter.py b/package_linter.py index 2883784..90d5b17 100755 --- a/package_linter.py +++ b/package_linter.py @@ -350,6 +350,16 @@ class App(): "No need to specify the choices list yourself." % argument["name"] ) + if argument["name"] == "is_public" and "help" not in argument.keys(): + print_warning( + "Consider adding an 'help' key for argument 'is_public' " + "to explain to the user what it means for *this* app " + "to be public or private :\n" + ' "help": {\n' + ' "en": "Some explanation"\n' + ' }') + + if "url" in manifest and manifest["url"].endswith("_ynh"): print_warning( "'url' is not meant to be the url of the yunohost package, "