YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Complain about placeholder values remaining in upstream section

Browse source
This commit is contained in:
Alexandre Aubin 2022-08-15 18:37:42 +02:00
parent 200fe99e1c
commit 664063a5d0
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
package_linter.py
View file

@ -1428,16 +1428,19 @@ class Manifest(TestSuite):
) )
@test() @test()
def upstream_fields_pointing_to_yunohost_doc(self): def upstream_placeholders(self):
if "upstream" in self.manifest.keys(): if "upstream" in self.manifest.keys():
if "yunohost.org" in self.manifest["upstream"].get("admindoc", ""): if "yunohost.org" in self.manifest["upstream"].get("admindoc", ""):
yield Info( yield Warning(
"The field 'admindoc' should point to the **official** admin doc, not the YunoHost documentation. If there's no official admin doc, simply remove the admindoc key entirely." "The field 'admindoc' should point to the **official** admin doc, not the YunoHost documentation. If there's no official admin doc, simply remove the admindoc key entirely."
) )
if "yunohost.org" in self.manifest["upstream"].get("userdoc", ""): if "yunohost.org" in self.manifest["upstream"].get("userdoc", ""):
yield Info( yield Warning(
"The field 'userdoc' should point to the **official** user doc, not the YunoHost documentation. (The default auto-generated README already includes a link to the yunohost doc page for this app). If there's no official user doc, simply remove the userdoc key entirely." "The field 'userdoc' should point to the **official** user doc, not the YunoHost documentation. (The default auto-generated README already includes a link to the yunohost doc page for this app). If there's no official user doc, simply remove the userdoc key entirely."
) )
if "example.com" in self.manifest["upstream"].get("demo", "") or "example.com" in self.manifest["upstream"].get("website"):
yield Warning("It seems like the upstream section still contains placeholder values such as 'example.com' ...")
@test() @test()
def yunohost_version_requirement(self): def yunohost_version_requirement(self):
@ -1502,6 +1505,9 @@ class Manifest(TestSuite):
) )
return return
if "upstream" in self.manifest and self.manifest["upstream"] != self.manifest["license"]:
yield Warning("The content of 'license' in the 'upstream' block should be the same as 'license' (yes sorry, this is duplicate info, this is transitional for the manifest v2 ...)")
@test() @test()
def description(self): def description(self):