YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix forbidden data location test..

Browse source
This commit is contained in:
Alexandre Aubin 2021-03-11 19:50:01 +01:00
parent 4effddeab1
commit 6ce44da797
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
package_linter.py
View file

@ -584,10 +584,11 @@ class App(TestSuite):
@test() @test()
def app_data_in_unofficial_dir(self): def app_data_in_unofficial_dir(self):
allowed_locations = ["yunohost.app", "yunohost.conf", "yunohost.backup", "yunohost.multimedia"] allowed_locations = ["/home/yunohost.app", "/home/yunohost.conf", "/home/yunohost.backup", "/home/yunohost.multimedia"]
cmd = "grep -IhEro '/home/yunohost[^/ ]*/' %s/scripts || true" % self.path cmd = "grep -IhEro '/home/yunohost[^/ ]*/' %s/scripts || true" % self.path
home_locations = subprocess.check_output(cmd, shell=True).decode('utf-8').strip().split("\n") home_locations = subprocess.check_output(cmd, shell=True).decode('utf-8').strip().split("\n")
forbidden_locations = set([location for location in home_locations if location and location not in allowed_locations])
forbidden_locations = set([location for location in home_locations if location and location.rstrip('/') not in allowed_locations])
if forbidden_locations: if forbidden_locations:
yield Warning("The app seems to be storing data in the 'forbidden' locations %s. The recommended pratice is rather to store data in /home/yunohost.app/$app or /home/yunohost.multimedia (depending on the use case)" % ', '.join(forbidden_locations)) yield Warning("The app seems to be storing data in the 'forbidden' locations %s. The recommended pratice is rather to store data in /home/yunohost.app/$app or /home/yunohost.multimedia (depending on the use case)" % ', '.join(forbidden_locations))