YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Cache license from spdx to avoid a 1-2 sec delay each time it's ran ...

Browse source
This commit is contained in:
Alexandre Aubin 2020-03-31 04:27:41 +02:00
parent 41e4f50d9f
commit 804bfbd55d
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
package_linter.py
View file

@ -84,6 +84,16 @@ def urlopen(url):
def file_exists(file_path): def file_exists(file_path):
return os.path.isfile(file_path) and os.stat(file_path).st_size > 0 return os.path.isfile(file_path) and os.stat(file_path).st_size > 0
def spdx_licenses():
cachefile = ".spdx_licenses"
if os.path.exists(cachefile):
return open(cachefile).read()
link = "https://spdx.org/licenses/"
content = urlopen(link)['content']
open(cachefile, "w").write(content)
return content
# ############################################################################ # ############################################################################
# Actual high-level checks # Actual high-level checks
@ -300,7 +310,6 @@ class App():
if "license" in manifest: if "license" in manifest:
for license in manifest['license'].replace('&', ',').split(','): for license in manifest['license'].replace('&', ',').split(','):
code_license = '<code property="spdx:licenseId">' + license + '</code>' code_license = '<code property="spdx:licenseId">' + license + '</code>'
link = "https://spdx.org/licenses/"
if license == "nonfree": if license == "nonfree":
print_warning("[YEP-1.3] The correct value for non free license in license field is 'non-free' and not 'nonfree'") print_warning("[YEP-1.3] The correct value for non free license in license field is 'non-free' and not 'nonfree'")
license = "non-free" license = "non-free"
@ -315,7 +324,7 @@ class App():
"[YEP-1.3] 'non-free' apps can't be officialized. " "[YEP-1.3] 'non-free' apps can't be officialized. "
" Their integration is still being discussed, especially for apps with non-free dependencies" " Their integration is still being discussed, especially for apps with non-free dependencies"
) )
elif code_license not in urlopen(link)['content']: elif code_license not in spdx_licenses():
print_warning( print_warning(
"[YEP-1.3] The license '%s' is not registered in https://spdx.org/licenses/ . " "[YEP-1.3] The license '%s' is not registered in https://spdx.org/licenses/ . "
"It can be a typo error. If not, you should replace it by 'free' " "It can be a typo error. If not, you should replace it by 'free' "