YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Complain about the usage of YNH_DEFAULT_PHP_VERSION in _common.sh

Browse source
This commit is contained in:
Alexandre Aubin 2023-06-19 16:16:33 +02:00
parent a640c914df
commit 809c45601d
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
package_linter.py
View file

@ -2420,6 +2420,11 @@ class Script(TestSuite):
"permission system: it should not be needed to save is_public with ynh_app_setting_set ... this setting should only be used during installation to initialize the permission. The admin is likely to manually tweak the permission using YunoHost's interface later."
)
@test(only=["_common.sh"])
def default_php_version_in_common(self):
if self.contains("YNH_DEFAULT_PHP_VERSION"):
yield Warning("Do not use YNH_DEFAULT_PHP_VERSION in _common.sh ... _common.sh is usually sourced *before* the helpers, which define the version of YNH_DEFAULT_PHP_VERSION (hence it gets replaced with empty string). Instead, please explicitly state the PHP version in the package, e.g. dependencies='php8.2-cli php8.2-imagemagick'")
@test(ignore=["install", "_common.sh"])
def get_is_public_setting(self):
if self.contains("is_public=") or self.contains("$is_public"):