YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Change the test for the license key: expect a license ID listed on spxd. I really doubt we need to cover the case of "the license is free but not listed on spdx" ... Spdx's list is quite exhaustive...

Browse source
This commit is contained in:
Alexandre Aubin 2020-11-18 20:27:03 +01:00
parent 91cd621e0c
commit 8970d3b960
1 changed files with 5 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
package_linter.py
View file

@ -880,36 +880,22 @@ class Manifest(TestSuite):
@test() @test()
def license(self): def license(self):
if not "license" in self.manifest: if "license" not in self.manifest:
return return
def license_mentionned_in_readme():
readme_path = os.path.join(self.path, 'README.md')
if os.path.isfile(readme_path):
return "LICENSE" in open(readme_path).read()
return False
license = self.manifest["license"] license = self.manifest["license"]
if "nonfree" in license.replace("-", ""): if "nonfree" in license.replace("-", ""):
yield Warning("'non-free' apps cannot be integrated in YunoHost's app catalog.") yield Warning("'non-free' apps cannot be integrated in YunoHost's app catalog.")
return
code_license = '<code property="spdx:licenseId">' + license + '</code>' code_license = '<code property="spdx:licenseId">' + license + '</code>'
if license == "free" and not license_mentionned_in_readme(): if code_license not in spdx_licenses():
yield Warning( yield Warning(
"Setting the license as 'free' implies to write something about it in " "The license id '%s' is not registered in https://spdx.org/licenses/." % license
"the README.md. Alternatively, consider using one of the codes available "
"on https://spdx.org/licenses/"
)
elif code_license not in spdx_licenses():
yield Warning(
"The license id '%s' is not registered in https://spdx.org/licenses/. "
"It can be a typo error. If not, you should replace it by 'free' "
"or 'non-free' and give some explanations in the README.md." % (license)
) )
return
@test() @test()
def description(self): def description(self):