YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

[mod] remove todo comments. Move them to #8 and #9.

Browse source
This commit is contained in:
Moul 2016-11-25 18:05:13 +01:00
parent f3dd498b62
commit 8ecf91dac8
1 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
package_linter.py
View file

@ -80,13 +80,8 @@ def check_manifest(manifest):
print_wrong("\"" + fields[i] + "\" field is missing") print_wrong("\"" + fields[i] + "\" field is missing")
i += 1 i += 1
""" """
Check values in keys Check values in keys
""" """
# Check under array
# manifest["description"]["en"]
# manifest["maintainer"]["name"]
# manifest["maintainer"]["email"]
# manifest["arguments"]["install"]
pf = 1 pf = 1
if "packaging_format" not in manifest: if "packaging_format" not in manifest:
print_wrong("\"packaging_format\" key is missing") print_wrong("\"packaging_format\" key is missing")
@ -249,17 +244,3 @@ if __name__ == '__main__':
while i < len(scripts): while i < len(scripts):
check_script(app_path, scripts[i]) check_script(app_path, scripts[i])
i += 1 i += 1
"""
## Todo ##
* Si nginx dans les services du manifest, vérifier :
* présence de /conf/nginx.conf
* sudo service reload nginx dans les scripts install, remove, upgrade, restore (backup n’est pas nécessaire)
* Helper propositions
if "apt" in install: print("You should use this helper: \"sudo yunohost \".")
* use jsonchema to check the manifest
https://github.com/YunoHost/yunotest/blob/master/apps_tests/manifest_schema.json
https://github.com/YunoHost/yunotest/blob/master/apps_tests/__init__.py
"""