From 94e81683ab68c716f2688b1cfd7015bdd146fbc5 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Wed, 4 Nov 2020 14:06:17 +0100 Subject: [PATCH] change_url script is only relevant if this is a webapp --- package_linter.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package_linter.py b/package_linter.py index 886b065..3374845 100755 --- a/package_linter.py +++ b/package_linter.py @@ -450,7 +450,8 @@ class App(TestSuite): @test() def change_url_script(app): - if not file_exists(app.path + "/scripts/change_url"): + has_domain_arg = any(a["name"] == "is_public" for a in app.manifest["arguments"].get("install", [])) + if has_domain_arg and not file_exists(app.path + "/scripts/change_url"): yield Warning("Consider adding a change_url script to support changing where the app is installed") @test()