YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Report usage of install_extra_app_dependencies without --key

Browse source
This commit is contained in:
Alexandre Aubin 2021-10-10 13:38:52 +02:00
parent 2fe4ae8b3a
commit 97f2441cf4
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
package_linter.py
View file

@ -549,7 +549,6 @@ class App(TestSuite):
message = "Using official helper %s implies requiring at least version %s, but manifest only requires %s" % (helper, helper_req, yunohost_version_req)
yield Error(message) if major_diff else (Info(message) if minor_diff else Warning(message))
@test()
def helper_consistency_apt_deps(app):
"""
@ -563,6 +562,10 @@ class App(TestSuite):
if app.scripts[name].exists and not app.scripts[name].contains("ynh_install_app_dependencies"):
yield Warning("ynh_install_app_dependencies should also be in %s script" % name)
cmd = 'grep -IhEr "install_extra_app_dependencies" %s/scripts | grep -v "key" | grep -q "http://"' % app.path
if os.system(cmd) == 0:
yield Info("When installing dependencies from extra repository, please include a `--key` argument (yes, even if it's official debian repos such as backports - because systems like Raspbian do not ship Debian's key by default!")
@test()
def helper_consistency_service_add(app):