YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Check for duplicated key in json + empty description

Browse source
This commit is contained in:
Alexandre Aubin 2019-03-09 19:54:55 +01:00
parent f99f2ff5a1
commit 9867d11ff8
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
package_linter.py
View file

@ -17,6 +17,16 @@ return_code = 0
# Utilities # Utilities
# ############################################################################ # ############################################################################
# Taken from https://stackoverflow.com/a/49518779
def check_for_duplicate_keys(ordered_pairs):
dict_out = {}
for key, val in ordered_pairs:
if key in dict_out:
print_warning("Duplicated key '%s' in %s" % (key, ordered_pairs))
else:
dict_out[key] = val
return dict_out
class c: class c:
HEADER = '\033[94m' HEADER = '\033[94m'
@ -199,7 +209,7 @@ class App():
try: try:
with open(manifest, encoding='utf-8') as data_file: with open(manifest, encoding='utf-8') as data_file:
manifest = json.loads(data_file.read()) manifest = json.loads(data_file.read(), object_pairs_hook=check_for_duplicate_keys)
except: except:
print_error("[YEP-2.1] Syntax (comma) or encoding issue with manifest.json. Can't check file.") print_error("[YEP-2.1] Syntax (comma) or encoding issue with manifest.json. Can't check file.")
@ -294,7 +304,7 @@ class App():
if isinstance(descr, dict): if isinstance(descr, dict):
descr = descr.get("en", None) descr = descr.get("en", None)
if descr is None or descr == manifest.get("name", None): if descr is None or descr == "" or descr == manifest.get("name", None):
print_warning( print_warning(
"[YEP-1.9] You should write a good description of the app, " "[YEP-1.9] You should write a good description of the app, "
"at least in english (1 line is enough)." "at least in english (1 line is enough)."