From a684cc4d1b2781c25476d76577a0e7b46ee95e9f Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Mon, 22 Feb 2021 18:00:03 +0100 Subject: [PATCH] Add checks for change_url script --- package_linter.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/package_linter.py b/package_linter.py index 779bfd0..335cec6 100755 --- a/package_linter.py +++ b/package_linter.py @@ -320,7 +320,7 @@ class TestSuite(): # Actual high-level checks # ############################################################################ -scriptnames = ["_common.sh", "install", "remove", "upgrade", "backup", "restore"] +scriptnames = ["_common.sh", "install", "remove", "upgrade", "backup", "restore", "change_url"] class App(TestSuite): @@ -532,6 +532,18 @@ class App(TestSuite): if app.scripts[name].exists and not app.scripts[name].contains("ynh_install_app_dependencies"): yield Warning("ynh_install_app_dependencies should also be in %s script" % name) + @test() + def consistency_changeurl_for_absolute_permissions_url(app): + + if not app.scripts["change_url"].exists: + return + + if app.scripts["install"].containsregex("ynh_app_setting_set.*ed_regex.*\$domain") and not app.scripts["change_url"].containsregex("ynh_app_setting_set.*ed_regex.*\$domain"): + yield Error("It looks like you added an absolute-url (regex?) legacy permission based on the domain, but change_url does not correctly propagate a possible domain change on that url") + + if app.scripts["install"].containsregex("ynh_permission_create.*url.*\$domain") and not app.scripts["change_url"].containsregex("ynh_permission_create.*url.*\$domain"): + yield Error("It looks like you added an absolute-url permission based on the domain, but change_url does not correctly propagate a possible domain change on that url") + @test() def helper_consistency_service_add(app):