YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #92 from YunoHost/report-legacy-permissions

Browse source 
Report legacy permission stuff (as info)
This commit is contained in:
Alexandre Aubin 2021-03-07 18:32:40 +01:00 committed by GitHub
commit abf751cd61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
package_linter.py
View file

@ -1385,6 +1385,21 @@ class Script(TestSuite):
"Use grep -q 'id: $appname' to check a specific app is installed"
)
@test()
def set_is_public_setting(self):
if self.containsregex(r'ynh_app_setting_set .*is_public.*'):
yield Info("permission system: it should not be needed to save is_public with ynh_app_setting_set ... this setting should only be used during installation to initialize the permission. The admin is likely to manually tweak the permission using Yunohost's interface later.")
@test(ignore=["install", "_common.sh"])
def get_is_public_setting(self):
if self.contains('is_public=') or self.contains('$is_public'):
yield Info("permission system: there should be no need to fetch or use $is_public ... is_public should only be used during installation to initialize the permission. The admin is likely to manually tweak the permission using Yunohost's interface later.")
@test()
def set_legacy_permissions(self):
if self.containsregex(r'ynh_app_setting_set .*protected_') or self.containsregex(r'ynh_app_setting_set .*skipped_'):
yield Info("permission system: it looks like the app is still using the legacy permission system (unprotected/protected/skipped uris/regexes setting). Please check https://yunohost.org/packaging_apps_permissions for a documentation on how to migrate the app to the new permission system.")
@test()
def normalize_url_path(self):
if self.contains("ynh_normalize_url_path"):