YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Begin to factorize script loading in an app class

Browse source
This commit is contained in:
Alexandre Aubin 2019-03-02 01:19:40 +01:00
parent e83b03b6d4
commit b089229482
1 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
package_linter.py
View file

@ -82,6 +82,16 @@ def file_exists(file_path):
# Actual high-level checks # Actual high-level checks
# ############################################################################ # ############################################################################
class App():
def __init__(self, path):
print_header("LOADING APP")
self.path = path
scripts = ["install", "remove", "upgrade", "backup", "restore"]
self.scripts = { f: Script(self.path, f) for f in scripts }
def check_files_exist(app_path): def check_files_exist(app_path):
""" """
@ -90,11 +100,10 @@ def check_files_exist(app_path):
""" """
print_header("MISSING FILES") print_header("MISSING FILES")
filenames = ("manifest.json", filenames = ("manifest.json", "LICENSE", "README.md",
"scripts/install", "scripts/remove", "scripts/install", "scripts/remove",
"scripts/upgrade", "scripts/upgrade",
"scripts/backup", "scripts/restore", "scripts/backup", "scripts/restore")
"LICENSE", "README.md")
non_mandatory = ("script/backup", "script/restore") non_mandatory = ("script/backup", "script/restore")
for filename in filenames: for filename in filenames:
@ -404,6 +413,7 @@ class Script():
self.exists = file_exists(self.path) self.exists = file_exists(self.path)
if not self.exists: if not self.exists:
return return
self.lines = list(self.read_file())
def read_file(self): def read_file(self):
with open(self.path) as f: with open(self.path) as f:
@ -421,7 +431,8 @@ class Script():
line = shlex.split(line, True) line = shlex.split(line, True)
yield line yield line
except Exception as e: except Exception as e:
print_warning("Could not parse this line (%s) : %s" % (e, line)) print_warning("%s : Could not parse this line (%s) : %s" % (self.path, e, line))
def contains(self, command): def contains(self, command):
""" """
@ -436,7 +447,6 @@ class Script():
def analyze(self): def analyze(self):
print_header(self.name.upper() + " SCRIPT") print_header(self.name.upper() + " SCRIPT")
self.lines = list(self.read_file())
check_verifications_done_before_modifying_system(self) check_verifications_done_before_modifying_system(self)
check_set_usage(self) check_set_usage(self)
@ -454,15 +464,13 @@ def main():
header(app_path) header(app_path)
# Global checks # Global checks
app = App(app_path)
check_files_exist(app_path) check_files_exist(app_path)
check_source_management(app_path) check_source_management(app_path)
check_manifest(app_path) check_manifest(app_path)
# Scripts checks # Scripts checks
scripts = ["install", "remove", "upgrade", "backup", "restore"] for script in app.scripts.values():
for script_name in scripts:
script = Script(app_path, script_name)
if script.exists: if script.exists:
script.analyze() script.analyze()