From b27a84820302e1717fedbf2e39f026300e67caf7 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sun, 10 Feb 2019 14:12:25 +0100 Subject: [PATCH] Recommend ynh_print_info or ynh_script_progression usage in the install script --- package_linter.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package_linter.py b/package_linter.py index aafdb84..9d38b33 100755 --- a/package_linter.py +++ b/package_linter.py @@ -427,6 +427,9 @@ def check_deprecated_practices(script): if "systemctl restart nginx" in script["raw"] or "service nginx restart" in script["raw"]: print_error("Restarting nginx is quite dangerous (especially for web installs) and should be avoided at all cost. Use 'reload' instead.") + if script["name"] == "install" and "ynh_print_info" not in script["shlex"] and "ynh_script_progression" not in script["shlex"]: + print_warning("Please add a few messages for the user, to explain what is going on (in friendly, not-too-technical terms) during the installation. You can use 'ynh_print_info' or 'ynh_script_progression' for this.") + def main(): if len(sys.argv) != 2: print("Give one app package path.")