YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

My_webapp has a legit case for chown root x_x

Browse source
This commit is contained in:
Alexandre Aubin 2024-07-23 20:49:50 +02:00
parent adf5c8464a
commit b6e024c395
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
package_linter.py
View file

@ -493,7 +493,7 @@ class App(TestSuite):
self.path = path self.path = path
self.manifest_ = Manifest(self.path) self.manifest_ = Manifest(self.path)
self.manifest = self.manifest_.manifest self.manifest = self.manifest_.manifest
self.scripts = {f: Script(self.path, f) for f in scriptnames} self.scripts = {f: Script(self.path, f, self.manifest.get("id")) for f in scriptnames}
self.configurations = Configurations(self) self.configurations = Configurations(self)
self.app_catalog = AppCatalog(self.manifest["id"]) self.app_catalog = AppCatalog(self.manifest["id"])
@ -2262,9 +2262,10 @@ class AppCatalog(TestSuite):
# |_| # # |_| #
################################## ##################################
class Script(TestSuite): class Script(TestSuite):
def __init__(self, app_path, name): def __init__(self, app_path, name, app_id):
self.name = name self.name = name
self.app_path = app_path self.app_path = app_path
self.app_id = app_id
self.path = app_path + "/scripts/" + name self.path = app_path + "/scripts/" + name
self.exists = file_exists(self.path) self.exists = file_exists(self.path)
if not self.exists: if not self.exists:
@ -2689,6 +2690,11 @@ class Script(TestSuite):
@test() @test()
def chownroot(self): def chownroot(self):
# Mywebapp has a legit use case for this >_>
if self.app_id == "my_webapp":
return
if self.containsregex( if self.containsregex(
r"^\s*chown.* root:?[^$]* .*install_dir" r"^\s*chown.* root:?[^$]* .*install_dir"
) and not self.contains('chown root:root "$install_dir"'): ) and not self.contains('chown root:root "$install_dir"'):