YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

screenshots: requalify size check to Warning because we're preparing screenshots integration in the webadmin + add accepted extensions check

Browse source
This commit is contained in:
Alexandre Aubin 2022-12-03 18:12:01 +01:00
parent 8332531956
commit bbd00502ad
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
package_linter.py
View file

@ -549,7 +549,12 @@ class App(TestSuite):
du_output = subprocess.check_output(["du", "-sb", app.path + "/doc/screenshots"], shell=False) du_output = subprocess.check_output(["du", "-sb", app.path + "/doc/screenshots"], shell=False)
screenshots_size = int(du_output.split()[0]) screenshots_size = int(du_output.split()[0])
if screenshots_size > 512000: if screenshots_size > 512000:
yield Info("Consider keeping the content of doc/screenshots under ~512Kb for better UI/UX once the screenshots will be integrated in the webadmin app's catalog (to be discussed with the team)") yield Warning("Consider keeping the content of doc/screenshots under ~512Kb for better UI/UX once the screenshots will be integrated in the webadmin app's catalog (to be discussed with the team)")
for path in os.listdir(app.path + "/doc/screenshots"):
if all(not path.lower().endswith(ext) for ext in [".jpg", ".jpeg", ".png", ".gif", ".webp"]):
yield Warning("In the doc/screenshots folder, only .jpg, .jpeg, .png, .webp and .gif are accepted")
break
@test() @test()
def doc_dir_v2(app): def doc_dir_v2(app):