From c1f2bfe5361d5e3aa5316c26d9354cbd2e63880f Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Tue, 24 Nov 2020 03:25:45 +0100 Subject: [PATCH] Recommend to add --quiet when using raw systemclt enable/disable --- package_linter.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/package_linter.py b/package_linter.py index 4638409..ebb5879 100755 --- a/package_linter.py +++ b/package_linter.py @@ -1141,6 +1141,17 @@ class Script(TestSuite): "and should be avoided at all cost. Use 'reload' instead." ) + @test() + def quiet_systemctl_enable(self): + + systemctl_enable = [line + for line in [' '.join(line) for line in self.lines] + if re.search(r"systemctl.*(enable|disable)", line)] + + if any("-q" not in cmd for cmd in systemctl_enable): + message = "Please add --quiet to systemctl enable/disable commands to avoid unecessary warnings when the script runs" + yield Warning(message) if self.name in ["_common.sh", "install"] else Info(message) + @test(only=["install"]) def argument_fetching(self):