From c7d1bf2138ae6c132a56613ed1e53e72481100fb Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Tue, 9 Aug 2022 19:00:28 +0200 Subject: [PATCH] Report default app description in manifest --- package_linter.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/package_linter.py b/package_linter.py index 83e8f98..69955f3 100755 --- a/package_linter.py +++ b/package_linter.py @@ -606,6 +606,16 @@ class App(TestSuite): "Sounds like your manifest.json contains some default placeholder help string ('Use the help field to...') ... either replace it with an actually helpful explanation, or remove the help string entirely if you don't use it." ) + if ( + os.system( + "grep -q 'Explain in *a few (10~15) words* the purpose of the app\|Expliquez en *quelques* (10~15) mots' %s/manifest.json 2>/dev/null" % self.path + ) + == 0 + ): + yield Warning( + "Sounds like your manifest.json contains the default description string ('Explain in *a few (10~15 words) [...]') ... Please replace it with an actual description." + ) + @test() def remaining_replacebyyourapp(self): if os.system("grep -I -qr 'REPLACEBYYOURAPP' %s 2>/dev/null" % self.path) == 0: