YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Turn some error into critical ?

Browse source
This commit is contained in:
Alexandre Aubin 2020-11-21 00:33:09 +01:00
parent a682a34454
commit ce36805ad5
1 changed files with 23 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
package_linter.py
View file

@ -195,7 +195,8 @@ class Info(TestReport):
class Success(TestReport): class Success(TestReport):
style = c.OKGREEN + " ☺ %s ♥" + c.END style = c.OKGREEN + " ☺ %s ♥" + c.END
class Critical(TestReport):
style = c.FAIL + " ✘✘✘ %s" + c.END
def header(app): def header(app):
_print(""" _print("""
@ -262,10 +263,11 @@ def spdx_licenses():
tests = {} tests = {}
tests_reports = { tests_reports = {
"success": [],
"info": [],
"warning": [], "warning": [],
"error": [], "error": [],
"info": [], "critical": [],
"success": [],
} }
def test(**kwargs): def test(**kwargs):
@ -345,19 +347,22 @@ class App(TestSuite):
if output == "json": if output == "json":
print(json.dumps({ print(json.dumps({
"success": [test for test, _ in tests_reports["success"]],
"info": [test for test, _ in tests_reports["info"]],
"warning": [test for test, _ in tests_reports["warning"]], "warning": [test for test, _ in tests_reports["warning"]],
"error": [test for test, _ in tests_reports["error"]], "error": [test for test, _ in tests_reports["error"]],
"success": [test for test, _ in tests_reports["success"]], "critical": [test for test, _ in tests_reports["critical"]],
"info": [test for test, _ in tests_reports["info"]]
}, indent=4)) }, indent=4))
return return
if tests_reports["error"]: if tests_reports["error"] or tests_reports["critical"]:
sys.exit(1) sys.exit(1)
def qualify_for_level_7(self): def qualify_for_level_7(self):
if tests_reports["error"]: if tests_reports["critical"]:
_print(" There are some critical issues in this app :(")
elif tests_reports["error"]:
_print(" Uhoh there are some errors to be fixed :(") _print(" Uhoh there are some errors to be fixed :(")
elif len(tests_reports["warning"]) > 3: elif len(tests_reports["warning"]) > 3:
_print(" Still some warnings to be fixed :s") _print(" Still some warnings to be fixed :s")
@ -839,7 +844,7 @@ class Manifest(TestSuite):
missing_fields = [field for field in fields if field not in self.manifest.keys()] missing_fields = [field for field in fields if field not in self.manifest.keys()]
if missing_fields: if missing_fields:
yield Error("The following mandatory fields are missing: %s" % missing_fields) yield Critical("The following mandatory fields are missing: %s" % missing_fields)
fields = ("license", "url") fields = ("license", "url")
missing_fields = [field for field in fields if field not in self.manifest.keys()] missing_fields = [field for field in fields if field not in self.manifest.keys()]
@ -851,14 +856,14 @@ class Manifest(TestSuite):
def yunohost_version_requirement(self): def yunohost_version_requirement(self):
if not self.manifest.get("requirements", {}).get("yunohost", ""): if not self.manifest.get("requirements", {}).get("yunohost", ""):
yield Error("You should add a yunohost version requirement in the manifest") yield Critical("You should add a yunohost version requirement in the manifest")
@test() @test()
def yunohost_version_requirement_superold(app): def yunohost_version_requirement_superold(app):
yunohost_version_req = app.manifest.get("requirements", {}).get("yunohost", "").strip(">= ") yunohost_version_req = app.manifest.get("requirements", {}).get("yunohost", "").strip(">= ")
if yunohost_version_req.startswith("2."): if yunohost_version_req.startswith("2."):
yield Error("Your app only requires yunohost >= 2.x, which tends to indicate that your app may not be up to date with recommended packaging practices and helpers.") yield Critical("Your app only requires yunohost >= 2.x, which tends to indicate that your app may not be up to date with recommended packaging practices and helpers.")
@test() @test()
def basic_fields_format(self): def basic_fields_format(self):
@ -1031,7 +1036,7 @@ class AppCatalog(TestSuite):
def is_in_catalog(self): def is_in_catalog(self):
if not self.catalog_infos: if not self.catalog_infos:
yield Warning("This app is not in YunoHost's application catalog") yield Critical("This app is not in YunoHost's application catalog")
@test() @test()
def revision_is_HEAD(self): def revision_is_HEAD(self):
@ -1043,7 +1048,7 @@ class AppCatalog(TestSuite):
def state_is_working(self): def state_is_working(self):
if self.catalog_infos and self.catalog_infos.get("state", "working") != "working": if self.catalog_infos and self.catalog_infos.get("state", "working") != "working":
yield Warning("The application is not flagged as working in YunoHost's apps catalog") yield Critical("The application is not flagged as working in YunoHost's apps catalog")
@test() @test()
def has_category(self): def has_category(self):
@ -1247,15 +1252,15 @@ class Script(TestSuite):
@test() @test()
def obsolete_helpers(self): def obsolete_helpers(self):
if self.contains("yunohost app setting"): if self.contains("yunohost app setting"):
yield Error("Do not use 'yunohost app setting' directly. Please use 'ynh_app_setting_(set,get,delete)' instead.") yield Critical("Do not use 'yunohost app setting' directly. Please use 'ynh_app_setting_(set,get,delete)' instead.")
if self.contains("yunohost app checkurl"): if self.contains("yunohost app checkurl"):
yield Error("'yunohost app checkurl' is obsolete!!! Please use 'ynh_webpath_register' instead.") yield Critical("'yunohost app checkurl' is obsolete!!! Please use 'ynh_webpath_register' instead.")
if self.contains("yunohost app checkport"): if self.contains("yunohost app checkport"):
yield Error("'yunohost app checkport' is obsolete!!! Please use 'ynh_find_port' instead.") yield Critical("'yunohost app checkport' is obsolete!!! Please use 'ynh_find_port' instead.")
if self.contains("yunohost app initdb"): if self.contains("yunohost app initdb"):
yield Error("'yunohost app initdb' is obsolete!!! Please use 'ynh_mysql_setup_db' instead.") yield Critical("'yunohost app initdb' is obsolete!!! Please use 'ynh_mysql_setup_db' instead.")
if self.contains("yunohost tools port-available"): if self.contains("yunohost tools port-available"):
yield Error("'yunohost tools port-available is obsolete!!! Please use 'ynh_port_available' instead.") yield Critical("'yunohost tools port-available is obsolete!!! Please use 'ynh_port_available' instead.")
if self.contains("yunohost app list -i") or self.contains("yunohost app list --installed"): if self.contains("yunohost app list -i") or self.contains("yunohost app list --installed"):
yield Warning( yield Warning(
"Argument --installed ain't needed anymore when using " "Argument --installed ain't needed anymore when using "
@ -1281,7 +1286,7 @@ class Script(TestSuite):
def argument_fetching(self): def argument_fetching(self):
if self.containsregex(r"^\w+\=\$\{?[0-9]"): if self.containsregex(r"^\w+\=\$\{?[0-9]"):
yield Error( yield Critical(
"Do not fetch arguments from manifest using variable=$N (e.g." "Do not fetch arguments from manifest using variable=$N (e.g."
" domain=$1 ...) Instead, use name=$YNH_APP_ARG_NAME" " domain=$1 ...) Instead, use name=$YNH_APP_ARG_NAME"
) )