YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #23 from YunoHost/rm_sudo_check

Browse source 
[mod] #5: remove 'sudo' cmd prefix check for YnH 2.6.
This commit is contained in:
M5oul 2017-04-05 20:49:44 +02:00 committed by GitHub
commit dc2b02dcbe
1 changed files with 0 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
package_linter.py
View file

@ -181,7 +181,6 @@ def check_script(path, script_name, script_nbr):
script = read_file(script_path)
return_code = check_sudo_prefix_commands(script) or return_code
return_code = check_non_helpers_usage(script) or return_code
if script_nbr < 5:
return_code = check_verifications_done_before_modifying_system(script) or return_code
@ -191,31 +190,6 @@ def check_script(path, script_name, script_nbr):
return return_code
def check_sudo_prefix_commands(script):
"""
Check if commands are prefix with "sudo"
"""
cmds = ("rm", "chown", "chmod", "apt-get", "apt",
"service", "yunohost", "find" "swapon", "mkswap", "useradd") # , "dd") cp, mkdir
ok = True
for line_nbr, line in enumerate(script):
for cmd in cmds:
if cmd + " " in line and "sudo " + cmd + " " not in line \
and "yunohost service" not in line and "-exec " + cmd not in line \
and ".service" not in line and line[0] != '#':
print(c.FAIL + "✘ Line ", line_nbr + 1,
"you should add \"sudo\" before this command line:", c.END)
print(" " + line.replace(cmd,
c.BOLD + c.FAIL + cmd + c.END))
ok = False
if ok:
print_right("All commands are prefix with \"sudo\".")
return 0
return 1
def check_verifications_done_before_modifying_system(script):
"""
Check if verifications are done before modifying the system