YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Smarter regexes for sed -i subsitutions detections

Browse source
This commit is contained in:
Alexandre Aubin 2020-04-03 15:32:30 +02:00
parent d34e840d84
commit dda9bcf5e7
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
package_linter.py
View file

@ -712,7 +712,7 @@ class Script():
For instance, "app setting" is contained in "yunohost app setting $app ..." For instance, "app setting" is contained in "yunohost app setting $app ..."
""" """
return any(re.match(regex, line) return any(re.search(regex, line)
for line in [' '.join(line) for line in self.lines]) for line in [' '.join(line) for line in self.lines])
def analyze(self): def analyze(self):
@ -799,8 +799,9 @@ class Script():
if self.contains("rm -rf"): if self.contains("rm -rf"):
print_error("[YEP-2.12] You should avoid using 'rm -rf', please use 'ynh_secure_remove' instead") print_error("[YEP-2.12] You should avoid using 'rm -rf', please use 'ynh_secure_remove' instead")
if self.contains("sed -i"):
print_warning("[YEP-2.12] You should avoid using 'sed -i', please use 'ynh_replace_string' instead") if self.containsregex(r"sed\s+(-i|--in-place)\s+(-r\s+)?s") or self.containsregex(r"sed\s+s\S*\s+(-i|--in-place)"):
print_warning("[YEP-2.12] You should avoid using 'sed -i' for substitutions, please use 'ynh_replace_string' instead")
if self.containsregex(r"sudo \w"): # \w is here to not match sudo -u, legit use because ynh_exec_as not official yet... if self.containsregex(r"sudo \w"): # \w is here to not match sudo -u, legit use because ynh_exec_as not official yet...
print_warning( print_warning(
"[YEP-2.12] You should not need to use 'sudo', the script is being run as root. " "[YEP-2.12] You should not need to use 'sudo', the script is being run as root. "