YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use generic function to check scripts.

Browse source
This commit is contained in:
Moul 2016-01-31 14:18:59 +01:00
parent 166ad9b7a8
commit eb5bfa2762
1 changed files with 14 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
package_checker.py
View file

@ -95,23 +95,17 @@ def check_manifest(manifest):
print("You should specify " + types[i] + " type: \"type\": \"" + types[i] + "\",") print("You should specify " + types[i] + " type: \"type\": \"" + types[i] + "\",")
j+=1 j+=1
i+=1 i+=1
def check_install_script(install_path):
if check_file_exist(install_path) == 0: return
print (c.BOLD + c.HEADER + "\n>>>> INSTALL SCRIPT <<<<" + c.END);
install = read_file(install_path)
check_script_header_presence(install)
check_sudo_prefix_commands(install)
check_verifications_done_before_modifying_system(install)
if "wget" in install or "curl" in install:
print("You should not fetch sources from internet with curl or wget for security reasons.")
def check_remove_script(remove_path): def check_scripts(path, script_name):
if check_file_exist(remove_path) == 0: return script_path = path + "/scripts/" + script_name
print (c.BOLD + c.HEADER + "\n>>>> REMOVE SCRIPT <<<<" + c.END); if check_file_exist(script_path) == 0: return
remove = read_file(remove_path) print (c.BOLD + c.HEADER + "\n>>>>", scripts[i].upper(), "SCRIPT <<<<" + c.END);
check_script_header_presence(remove) script = read_file(script_path)
check_sudo_prefix_commands(remove) check_script_header_presence(script)
check_verifications_done_before_modifying_system(remove) check_sudo_prefix_commands(script)
check_verifications_done_before_modifying_system(script)
if "wget" in script or "curl" in script:
print("You should not fetch sources from internet with curl or wget for security reasons.")
def check_script_header_presence(script): def check_script_header_presence(script):
if "#!/bin/bash" in script[0]: print_right("Script contain at first line \"#!/bin/bash\"") if "#!/bin/bash" in script[0]: print_right("Script contain at first line \"#!/bin/bash\"")
@ -166,14 +160,10 @@ if __name__ == '__main__':
header(app_path) header(app_path)
check_files_exist(app_path) check_files_exist(app_path)
check_manifest(app_path + "/manifest.json") check_manifest(app_path + "/manifest.json")
check_install_script(app_path + "/scripts/install") i, scripts = 0, ("install", "remove", "upgrade", "backup", "restore")
check_remove_script(app_path + "/scripts/remove") while i < len(scripts):
""" check_scripts(app_path, scripts[i])
check_upgrade_script(app_path + "/scripts/upgrade") i+=1
check_backup_script(app_path + "/scripts/backup")
check_restore_script(app_path + "/scripts/restore")
"""
""" """
## Todo ## ## Todo ##