YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Report references to php5

Browse source
This commit is contained in:
Alexandre Aubin 2020-11-09 18:21:31 +01:00
parent 4b513b4cd6
commit f803acd1fd
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
package_linter.py
View file

@ -426,6 +426,10 @@ class App(TestSuite):
if not install_script.contains("--needs_exposed_ports"): if not install_script.contains("--needs_exposed_ports"):
yield Warning("The install script expose a port on the outside with 'yunohost firewall allow' but doesn't use 'yunohost service add' with --needs_exposed_ports ... If your are ABSOLUTELY SURE that the service needs to be exposed on THE OUTSIDE, then add --needs_exposed_ports to 'yunohost service add' with the relevant port number. Otherwise, opening the port leads to a significant security risk and you should keep the damn port closed !") yield Warning("The install script expose a port on the outside with 'yunohost firewall allow' but doesn't use 'yunohost service add' with --needs_exposed_ports ... If your are ABSOLUTELY SURE that the service needs to be exposed on THE OUTSIDE, then add --needs_exposed_ports to 'yunohost service add' with the relevant port number. Otherwise, opening the port leads to a significant security risk and you should keep the damn port closed !")
@test()
def references_to_old_php_versions(app):
if any(script.contains("/etc/php5") or script.contains("php5-fpm") for script in app.scripts.values() if script.exists):
yield Warning("This app still has references to php5 (from the jessie era !!) which tends to indicate that it's not up to date with recent packaging practices.")
########################################################### ###########################################################
# _____ __ __ _ # # _____ __ __ _ #
@ -504,7 +508,6 @@ class App(TestSuite):
if os.system(r"grep -q '^\s*backup_restore=1' %s" % check_process_file) != 0: if os.system(r"grep -q '^\s*backup_restore=1' %s" % check_process_file) != 0:
yield Warning("It looks like you forgot to enable backup_restore test in check_process ?") yield Warning("It looks like you forgot to enable backup_restore test in check_process ?")
@test() @test()
def misc_legacy_phpini(app): def misc_legacy_phpini(app):
@ -515,7 +518,6 @@ class App(TestSuite):
"(c.f. https://github.com/YunoHost-Apps/nextcloud_ynh/issues/138 )" "(c.f. https://github.com/YunoHost-Apps/nextcloud_ynh/issues/138 )"
) )
@test() @test()
def misc_source_management(app): def misc_source_management(app):
@ -530,7 +532,6 @@ class App(TestSuite):
"https://github.com/YunoHost/issues/issues/201#issuecomment-391549262" "https://github.com/YunoHost/issues/issues/201#issuecomment-391549262"
) )
@test() @test()
def misc_nginx_add_header(app): def misc_nginx_add_header(app):
@ -553,7 +554,6 @@ class App(TestSuite):
"and https://github.com/openresty/headers-more-nginx-module#more_set_headers )" "and https://github.com/openresty/headers-more-nginx-module#more_set_headers )"
) )
@test() @test()
def misc_nginx_path_traversal(app): def misc_nginx_path_traversal(app):
for filename in os.listdir(app.path + "/conf") if os.path.exists(app.path + "/conf") else []: for filename in os.listdir(app.path + "/conf") if os.path.exists(app.path + "/conf") else []: