Commit graph

368 commits

Author SHA1 Message Date
selfhoster1312
cbe1450d67 Change error to info and rephrase the message 2023-01-08 19:46:01 +01:00
selfhoster1312
e8fbcf6b5c Warn when using ynh_script_progression in _common.sh 2023-01-08 19:28:55 +01:00
Alexandre Aubin
3898d6ab1f Rework maintenance check because the info is now in the 'antifeatures' key in the catalog. Also refuse level 8 for apps flagged as deprecated, alpha or replaced by another app 2023-01-08 15:26:32 +01:00
Alexandre Aubin
b67409e3a8 Revert screenshot size warning to only info é_è 2022-12-23 23:31:16 +01:00
Alexandre Aubin
bd6ad626d9 Lazyload toml only when it's actually needed to simplify boring dependencies issues 2022-12-21 20:28:51 +01:00
Alexandre Aubin
935a984e95 Complain about 'website' in the manifest pointing to a code repo 2022-12-19 00:20:38 +01:00
Alexandre Aubin
b0cde49675 packagingv2: deprecate the nginx reload at the end of scripts ... there just no need for it :| 2022-12-04 03:30:45 +01:00
Alexandre Aubin
2ad2188805 Misc fixes 2022-12-04 03:24:45 +01:00
Alexandre Aubin
af8faf2088 Requalify a bunch of warning as error because the vast majority of apps now fixed these + complain about apps requiring only yunohost 4.0 / 4.1 + encourage usage of --usage/--footprint for php conf instead of huge php-fpm.conf 2022-12-03 20:13:41 +01:00
Alexandre Aubin
c205c300e7 Requalify utf8 check for .md file as Error 2022-12-03 19:13:36 +01:00
Alexandre Aubin
bbd00502ad screenshots: requalify size check to Warning because we're preparing screenshots integration in the webadmin + add accepted extensions check 2022-12-03 18:12:01 +01:00
Alexandre Aubin
8332531956 Adapt linter to support v2 packages 2022-11-27 18:16:33 +01:00
Alexandre Aubin
76e8d962e1 Update official helper list + ignore config panel helpers that may legitimately be overwritten 2022-10-21 22:30:42 +02:00
yalh76
5130c78675 Update package_linter.py 2022-10-02 22:13:17 +02:00
Alexandre Aubin
17ef2139fa Bump a few Infos as Warnings, and some Warnings as Errors 2022-08-29 22:27:19 +02:00
Alexandre Aubin
f3cc6142db fix: website key may not exist in manifest 2022-08-27 15:48:34 +02:00
Alexandre Aubin
22bdd73fe5 Using (un)protected_uris / skipped_uris settings is unacceptable nowadays 2022-08-16 23:38:40 +02:00
Alexandre Aubin
c2f55552d6 Report setting_set of is_public in upgrade script as an error ... the only apps still doing this have pending changes in testing to fix it 2022-08-16 23:32:48 +02:00
Alexandre Aubin
45f267a4ad Complain about admin having to finish the install manually... 2022-08-15 19:38:24 +02:00
Alexandre Aubin
7467713699 Oopsies 2022-08-15 19:36:37 +02:00
Alexandre Aubin
664063a5d0 Complain about placeholder values remaining in upstream section 2022-08-15 18:37:42 +02:00
Alexandre Aubin
200fe99e1c Complain about ynh_setup_source --keep used with absolute paths ... 2022-08-15 18:23:42 +02:00
Alexandre Aubin
f990b5215e Deprecate apps requiring only 3.x, + warning for app requring 4.0 (there's just a handful of those and most are old/notworking) 2022-08-13 17:36:18 +02:00
Alexandre Aubin
c7d1bf2138 Report default app description in manifest 2022-08-09 19:00:45 +02:00
Tagada
74104331e5
Merge pull request #104 from Tagadda/patch-1
Use an Info instead of a Warning for packages that are not in the YunoHost-Apps organisation
2022-05-15 12:47:50 +02:00
Alexandre Aubin
ee46f76b04 Advice to keep doc/screenshot under ~512Kb 2022-05-06 21:08:58 +02:00
Tagadda
22b5931946 Use an Info instead of a Warning for packages that are not in the YunoHost-Apps organisation 2022-03-21 12:25:10 +00:00
Alexandre Aubin
c0b225941f Complain about super old build statuses in README é_è 2022-01-25 00:56:06 +01:00
Alexandre Aubin
24e9c9574a Report an error if config panel is set to 1.0 but the config script is still using some super old stuff... 2022-01-25 00:12:14 +01:00
Alexandre Aubin
1721516624 Report root services as info instead of warning for Type=oneshot (because these usually are system stuff legitimately running as root) 2021-12-31 02:14:49 +01:00
Alexandre Aubin
e1cea41ae8 Flag set/get of is_public as warning ... is_public is really supposed to be only about initializing the perms ... Also add some advice about no need to temporarily add/remove visitors to the main permission for ynh_local_curl since 4.3 2021-12-05 00:36:29 +01:00
Alexandre Aubin
1a3841070d Lower long-term good quality treshold because some apps are stuck to level 7 just because they were level 0 during a few weeks despite being level 7+ for like two years 2021-12-05 00:19:37 +01:00
Alexandre Aubin
bd6cc2922a Stupid hack to ignore php-pear dependency triggering php_deps warning 2021-12-05 00:18:31 +01:00
Alexandre Aubin
4cee0da0bb Recategorize info as warning for stuff done by 99% of level 7+ apps 2021-12-04 23:54:46 +01:00
Alexandre Aubin
7a2a98a0da Return info instead of warning for bad_final_path_location ... 2021-12-04 19:19:32 +01:00
Alexandre Aubin
084ce4e314 Web applications are supposed to be installed in /var/www/$app, not /opt/ é_è ... 2021-12-04 19:03:08 +01:00
Alexandre Aubin
167f687643 Report deprecated http->https redirect in nginx conf 2021-11-20 22:25:31 +01:00
Alexandre Aubin
5c972a2607 Report config panels version 0.1 2021-11-14 21:36:38 +01:00
Alexandre Aubin
8f6aada99a Deprecated ynh_detect_arch in favor of $YNH_ARCH 2021-11-14 18:21:16 +01:00
Alexandre Aubin
28c515fe5e Report usage of ynh_exec_* and wrapping the command between quotes 2021-11-13 19:24:56 +01:00
Alexandre Aubin
92066d640f Update list of official helpers 2021-11-13 19:05:35 +01:00
Alexandre Aubin
6f44c322fd Add check for deprecated --package option for ynh_add_fpm_config 2021-11-13 19:00:56 +01:00
Sébastien Mennetrier
3056954eb3 Improve check of version in manifest 2021-10-28 15:24:32 +02:00
Sébastien Mennetrier
89969061f0 Udpate some links to documentation 2021-10-28 11:16:41 +02:00
Alexandre Aubin
d4c191c1ca Apply black 2021-10-24 14:33:41 +02:00
Alexandre Aubin
992f491e5e Don't grep doc/ if folder doesn't exist, should prevent some issues 2021-10-24 14:32:15 +02:00
Alexandre Aubin
a3272065dd Report remaining disclaimer placeholders being weird wording @_@ 2021-10-23 17:23:08 +02:00
Alexandre Aubin
1062a8d22e Report unknown-8bit too 2021-10-23 17:05:45 +02:00
Alexandre Aubin
d910c59d76 Aaaannnd I broke everything 2021-10-23 16:59:33 +02:00
Alexandre Aubin
c303c149a0 Report files encoded as latin1 2021-10-23 16:43:22 +02:00
Alexandre Aubin
42c44c31bd Unused weird 'codec' thingy 2021-10-23 16:15:50 +02:00
Alexandre Aubin
6a818a28c5 Aaaaaand typo >_> 2021-10-10 16:39:12 +02:00
Alexandre Aubin
e07d9c5133 Fix false positive warning for path traversal issue 2021-10-10 16:38:01 +02:00
Alexandre Aubin
97f2441cf4 Report usage of install_extra_app_dependencies without --key 2021-10-10 13:39:06 +02:00
Alexandre Aubin
2fe4ae8b3a Report /home/$app as a bad location for app data 2021-10-06 18:04:19 +02:00
Alexandre Aubin
1d96b4592a Suggest removing ynh_add_app_dependencies 2021-10-06 14:33:30 +02:00
Alexandre Aubin
9f45cc6fa3 Suggest removing references to jessie 2021-10-06 14:31:23 +02:00
Alexandre Aubin
6338aca006 Stupid typo leading to apps with exactly 3 warnings being able to reach level 7+ T_T 2021-10-01 04:08:15 +02:00
Alexandre Aubin
c4af75125a Report usage of 'chown root ' 2021-09-29 18:01:01 +02:00
Alexandre Aubin
ab8696322d Encourage to harden systemd configuration 2021-09-29 17:37:23 +02:00
Alexandre Aubin
5b6cde0562 Report missing ask strings in install questions 2021-09-29 15:22:43 +02:00
Alexandre Aubin
e1cbc527dc
set_legacy_permission to report a warning instead of info 2021-09-24 12:24:57 +02:00
tituspijean
a9b768481e Fix typos, rewordings 2021-09-23 22:28:00 +02:00
Alexandre Aubin
272910a42e No need to define default/example values for domain, user, passwords 2021-09-16 20:16:16 +02:00
Alexandre Aubin
18b26598da Report using of ynh_print_ON/OFF 2021-09-16 18:44:44 +02:00
Alexandre Aubin
6f71827858 Report useless ynh_webpath_available 2021-08-28 22:09:04 +02:00
Alexandre Aubin
1ef85021d4
path traversal issue: Ignore trailing simple quotes 2021-08-16 14:02:37 +02:00
Alexandre Aubin
8fb895d258 Promote some Info to Warning because the vast majority of level 7+ apps satisfy these 2021-08-07 17:14:18 +02:00
Alexandre Aubin
0dc32a65bd userdoc and admindoc fields shouldnt point to yunohost.org 2021-08-07 16:56:07 +02:00
Alexandre Aubin
5a558af536 Report references to php5 as error, + add warnings for reference to php7.0, or yunohost requirement before 3.8 2021-06-11 17:08:09 +02:00
Alexandre Aubin
d3403a701e Fix doc folder exists test 2021-05-13 19:49:20 +02:00
Alexandre Aubin
609580adb3 Don't miserably crash if there's nothing to grep 2021-05-10 21:15:55 +02:00
Alexandre Aubin
769aa810fc Recommend to use ynh_add_config 2021-05-10 21:12:07 +02:00
Alexandre Aubin
2874e9a6f7 Add an info to advertise the new auto README stuff, encourage to add a doc/DISCLAIMER.md + upstream infos in manifest 2021-05-10 20:17:58 +02:00
Alexandre Aubin
5b0371c46d Requalify some 'info' as 'warning' now that they integrated by the vast majority of good quality apps 2021-05-10 19:52:40 +02:00
Alexandre Aubin
5b455de1bd Report using --others_var as deprecated (as info) 2021-05-10 19:39:11 +02:00
Alexandre Aubin
08ff7404be Update official helper list 2021-05-10 18:00:49 +02:00
Alexandre Aubin
c9d2ae81ad Put an actual license in LICENSE 2021-04-23 18:34:39 +02:00
Alexandre Aubin
dc5cb76a40 Don't complain about app requesting 4.1.0 instead of 4.1.2 because meh 2021-04-16 22:26:14 +02:00
Alexandre Aubin
24f7031aee Don't break json output 2021-04-13 00:23:31 +02:00
Alexandre Aubin
59285decfc Don't miserably crash because of syntax error in apps.json 2021-04-11 19:58:15 +02:00
Alexandre Aubin
6fb6cdc15d Bump date in comment about helpers requirement 2021-04-11 17:13:59 +02:00
Alexandre Aubin
3393cfe0b8 Update helpers version requirements 2021-04-11 17:07:09 +02:00
Alexandre Aubin
975e2de5fc Add info about osbsolete/superflous ask strings 2021-03-15 02:26:41 +01:00
Alexandre Aubin
0b1aa10e44 Also report set -u used in remove, making some remove crash ... 2021-03-14 18:40:39 +01:00
Alexandre Aubin
6ce44da797 Fix forbidden data location test.. 2021-03-11 19:50:01 +01:00
Alexandre Aubin
4effddeab1 Report app using a folder in /home that aint the recommended practice /home/yunohost.app/ or multimedia 2021-03-11 02:59:34 +01:00
Alexandre Aubin
abf751cd61
Merge pull request #92 from YunoHost/report-legacy-permissions
Report legacy permission stuff (as info)
2021-03-07 18:32:40 +01:00
Alexandre Aubin
c8555839b2 Epic bug in json output wtf :| 2021-02-22 19:00:08 +01:00
Alexandre Aubin
5a3794957e Report legacy permission stuff (as info) 2021-02-21 18:31:06 +01:00
Alexandre Aubin
12117dad7d No need to differentiate if output == plain, _print handle this, we shoudl always add stuff to tests_reports 2021-02-03 18:42:50 +01:00
Alexandre Aubin
0c13d92b6d Polish the output for better UX? 2021-02-03 18:30:26 +01:00
Alexandre Aubin
adec1fdf02
Requalify the check that app is working as an Error instead of Critical because that's hella confusing for CI test on apps not yet in the catalog 2021-01-21 20:30:13 +01:00
Alexandre Aubin
9db63cc2ce Ignore binary file match derp 2021-01-17 15:32:34 +01:00
Alexandre Aubin
0e5c8a4504 Report default/placeholder help string + remaining REPLACEBYYOURAPP 2021-01-10 18:53:00 +01:00
Alexandre Aubin
d6bfb089c9 Report having a message talking about configuring firewall when it's only about finding an available port ... 2021-01-09 22:11:44 +01:00
Alexandre Aubin
8ba4a25b8b Report black magic with conf.json.persistent 2021-01-09 18:45:40 +01:00
ericgaspar
403fff1e7c
Update package_linter.py 2021-01-09 14:46:53 +01:00
Alexandre Aubin
360da39e15 Improved regex to avoid matching timer/target services 2021-01-07 18:43:58 +01:00
Alexandre Aubin
2650e4cc4b Report starting services with systemctl start instead of ynh_systemd_action 2021-01-07 18:37:51 +01:00