YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity
500 commits 2 branches 0 tags 568 KiB
Commit graph

414 commits

Author SHA1 Message Date
Kayou
e0813a39d9
Merge pull request #124 from YunoHost/nginx-check-regex-in-location-field 
nginx check regex in location field
 2024-02-20 07:54:05 +01:00
Kayou
375034c333
Merge pull request #125 from OniriCorpe/check-binb-public-ip 
add bind_public_ip check
 2024-02-20 07:53:29 +01:00
oleole39
7110959e51
Fix regex for source 
Current regex will match any of the ten line after the official helper files starting with the string "source". 
Thus, in my specific case for which I declare a variable named source_filename="{...}", the linter will display a warning for it: `    ! Please avoid sourcing additional helpers after the official helpers (in this case file _filename=$(basename$upstream__url)) `.
As it should be only interested in matching the command `source` (`source path/to/file`), a space should be appended to the current regex.
 2024-02-19 22:13:30 +01:00
Alexandre Aubin
8c00413d2f
Merge pull request #127 from orhtej2/more_set_headers_regex 
Allow multiple whitespace after 'more_set_headers'
 2024-02-12 20:08:36 +01:00
Alexandre Aubin
78b395ea68
Update package_linter.py 2024-02-12 20:08:14 +01:00
orhtej2
caee27ddaf Allow multiple whitespace after 'more_set_headers' 2024-02-10 21:32:56 +01:00
orhtej2
8ed7286c90 Show offending lines for 'more_set_headers' 2024-02-10 21:28:47 +01:00
Alexandre Aubin
d0c763ee28 Soft-deprecate packaging v1 on February 1st 2024, to be turned into an error on February 1st 2025 2024-01-26 15:22:09 +01:00
OniriCorpe
f3bf1b237b small refactor 2024-01-18 20:57:04 +01:00
OniriCorpe
051053d4fd tweak to ignore IPs like "10.0.0.0" 2024-01-18 03:46:37 +01:00
OniriCorpe
23b2f7d6bb better ip discrimination 2024-01-18 03:06:27 +01:00
OniriCorpe
8b38cf0924 mention the reverse proxy bypass 2024-01-17 23:51:38 +01:00
OniriCorpe
832dc3d55b add line numer and fix a trigger on commented lines 2024-01-17 23:37:25 +01:00
OniriCorpe
90ad5247a9 add bind_public_ip check 2024-01-17 23:23:06 +01:00
Alexandre Aubin
958bbe61e8 Don't miserably crash when failing to join() the error path when checking manifest schema 2024-01-17 03:48:26 +01:00
Kay0u
74d39d910c
oupsie 2023-12-29 00:52:27 +01:00
Kay0u
5baae31c1f
nginx check regex in location field 2023-12-29 00:48:47 +01:00
Alexandre Aubin
c989679ba3 Complain about using --line_match=Started/Stopped which is irrelevant/counterproductive 2023-12-28 05:15:30 +01:00
Alexandre Aubin
a8e5c7e67e Complain about using 'git clone' 2023-11-25 15:15:01 +01:00
Alexandre Aubin
67202bfa7b Tighten some info as 'warnings' (should only affect a handful of level 7+ apps nowadays) 2023-11-24 18:10:14 +01:00
Alexandre Aubin
cb892f1c42
Merge pull request #122 from orhtej2/flake8 
Fixed (most) linter complaints.
 2023-09-07 23:37:14 +02:00
orhtej2
3dcd83eb78 Fixed (most) linter complaints. 2023-09-07 23:11:03 +02:00
orhtej2
21815225cf
Consistently parse apt dependencies. 
Make "x y" proper list of dependencies [`x`, `y`]  rather that of [`x y`]
 2023-09-06 22:47:09 +02:00
Félix Piédallu
812fb0c996 Allow packages to be a list. Also, use the same splitting logic as in yunohost source code. 2023-09-06 13:53:54 +02:00
Alexandre Aubin
5d90885b49 phpconf: allow the usage of www-data for Group 2023-08-31 16:50:32 +02:00
tituspijean
afdefcc44b
Require init_main_permission question for webapps (#115) 
* Require init_main_permission question for webapps

* Require init_main_permission question for webapps, fixed

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>

* Factorize a bit init_main_permission warning

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>

* Enhance init_main_permission warning

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>

---------

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>
 2023-08-18 19:15:49 +02:00
tituspijean
0dd375db34 Fix jsonschema dependency installation 2023-07-25 20:32:20 +02:00
Alexandre Aubin
ea1f11b26b Add new schema validation for manifest v2 (only reports stuff as info for now) 2023-07-25 18:00:42 +02:00
Alexandre Aubin
6a5c346ecd nginx: complain about using $http_host rather than $host 2023-07-04 15:33:02 +02:00
Alexandre Aubin
50a325d27a Report http->https redirection as warning instead of info for app packaging v2 2023-07-04 15:12:10 +02:00
Alexandre Aubin
809c45601d Complain about the usage of YNH_DEFAULT_PHP_VERSION in _common.sh 2023-06-19 16:16:33 +02:00
Alexandre Aubin
a640c914df
manifest validation: missing 'continue' when some key doesnt exist to try to prevent miserably crashing (#113) 2023-06-10 23:50:05 +02:00
Alexandre Aubin
8fe93728bf
having group = 'www-data' is a legit use case in php conf 2023-05-04 23:47:49 +02:00
Alexandre Aubin
e5b29238b2 Recategorize error as warning because it's clearly too aggressive @_@ 2023-04-01 14:07:40 +02:00
Alexandre Aubin
f281436e88
Merge pull request #110 from YunoHost/fix-v2 
Fix location of PRE/POST_INSTALL.md files
 2023-03-14 02:43:40 +01:00
Alexandre Aubin
3052fc966f Improve parsing of apt packages in v2 manifests 2023-02-26 13:01:40 +01:00
tituspijean
880cfd8668
Fix location of PRE/POST_INSTALL.md files 2023-02-21 23:08:35 +01:00
Alexandre Aubin
f0b1c81a9a Complain about dummy/placeholder messages in the doc/ folder 2023-02-20 19:34:13 +01:00
Alexandre Aubin
1b4f99575e Moving warnings from the core about consistency for apt resources vs database requirement 2023-02-20 18:02:27 +01:00
Alexandre Aubin
c90526dbd6 Remove unecessary warning about apps.json not existing 2023-02-15 19:20:58 +01:00
Alexandre Aubin
5d75cc2a73 Bump use of --package option in ynh_add_fpm_config as an error, we really gotta get rid of this legacy stuff 2023-02-15 19:19:43 +01:00
Alexandre Aubin
078f29de39 The app's catalog is in json now 2023-01-20 17:57:01 +01:00
Alexandre Aubin
c8abbe21a6 Require new tests.toml for apps v2 2023-01-16 23:40:33 +01:00
Alexandre Aubin
9fc8e0fb78 Be more resilient in case upgrade/backup/restore script dont exist for some reason 2023-01-11 09:46:19 +01:00
Alexandre Aubin
0f9b9aec73 Make doc/ folder mandatory for packaging v2 2023-01-11 09:45:55 +01:00
Alexandre Aubin
d8162daf30
Merge pull request #109 from selfhoster1312/progress_common 
Warn when using ynh_script_progression in _common.sh
 2023-01-08 20:47:51 +01:00
selfhoster1312
cbe1450d67 Change error to info and rephrase the message 2023-01-08 19:46:01 +01:00
selfhoster1312
e8fbcf6b5c Warn when using ynh_script_progression in _common.sh 2023-01-08 19:28:55 +01:00
Alexandre Aubin
3898d6ab1f Rework maintenance check because the info is now in the 'antifeatures' key in the catalog. Also refuse level 8 for apps flagged as deprecated, alpha or replaced by another app 2023-01-08 15:26:32 +01:00
Alexandre Aubin
b67409e3a8 Revert screenshot size warning to only info é_è 2022-12-23 23:31:16 +01:00
Alexandre Aubin
bd6ad626d9 Lazyload toml only when it's actually needed to simplify boring dependencies issues 2022-12-21 20:28:51 +01:00
Alexandre Aubin
935a984e95 Complain about 'website' in the manifest pointing to a code repo 2022-12-19 00:20:38 +01:00
Alexandre Aubin
b0cde49675 packagingv2: deprecate the nginx reload at the end of scripts ... there just no need for it :| 2022-12-04 03:30:45 +01:00
Alexandre Aubin
2ad2188805 Misc fixes 2022-12-04 03:24:45 +01:00
Alexandre Aubin
af8faf2088 Requalify a bunch of warning as error because the vast majority of apps now fixed these + complain about apps requiring only yunohost 4.0 / 4.1 + encourage usage of --usage/--footprint for php conf instead of huge php-fpm.conf 2022-12-03 20:13:41 +01:00
Alexandre Aubin
c205c300e7 Requalify utf8 check for .md file as Error 2022-12-03 19:13:36 +01:00
Alexandre Aubin
bbd00502ad screenshots: requalify size check to Warning because we're preparing screenshots integration in the webadmin + add accepted extensions check 2022-12-03 18:12:01 +01:00
Alexandre Aubin
8332531956 Adapt linter to support v2 packages 2022-11-27 18:16:33 +01:00
Alexandre Aubin
76e8d962e1 Update official helper list + ignore config panel helpers that may legitimately be overwritten 2022-10-21 22:30:42 +02:00
yalh76
5130c78675 Update package_linter.py 2022-10-02 22:13:17 +02:00
Alexandre Aubin
17ef2139fa Bump a few Infos as Warnings, and some Warnings as Errors 2022-08-29 22:27:19 +02:00
Alexandre Aubin
f3cc6142db fix: website key may not exist in manifest 2022-08-27 15:48:34 +02:00
Alexandre Aubin
22bdd73fe5 Using (un)protected_uris / skipped_uris settings is unacceptable nowadays 2022-08-16 23:38:40 +02:00
Alexandre Aubin
c2f55552d6 Report setting_set of is_public in upgrade script as an error ... the only apps still doing this have pending changes in testing to fix it 2022-08-16 23:32:48 +02:00
Alexandre Aubin
45f267a4ad Complain about admin having to finish the install manually... 2022-08-15 19:38:24 +02:00
Alexandre Aubin
7467713699 Oopsies 2022-08-15 19:36:37 +02:00
Alexandre Aubin
664063a5d0 Complain about placeholder values remaining in upstream section 2022-08-15 18:37:42 +02:00
Alexandre Aubin
200fe99e1c Complain about ynh_setup_source --keep used with absolute paths ... 2022-08-15 18:23:42 +02:00
Alexandre Aubin
f990b5215e Deprecate apps requiring only 3.x, + warning for app requring 4.0 (there's just a handful of those and most are old/notworking) 2022-08-13 17:36:18 +02:00
Alexandre Aubin
c7d1bf2138 Report default app description in manifest 2022-08-09 19:00:45 +02:00
Tagada
74104331e5
Merge pull request #104 from Tagadda/patch-1 
Use an Info instead of a Warning for packages that are not in the YunoHost-Apps organisation
 2022-05-15 12:47:50 +02:00
Alexandre Aubin
ee46f76b04 Advice to keep doc/screenshot under ~512Kb 2022-05-06 21:08:58 +02:00
Tagadda
22b5931946 Use an Info instead of a Warning for packages that are not in the YunoHost-Apps organisation 2022-03-21 12:25:10 +00:00
Alexandre Aubin
c0b225941f Complain about super old build statuses in README é_è 2022-01-25 00:56:06 +01:00
Alexandre Aubin
24e9c9574a Report an error if config panel is set to 1.0 but the config script is still using some super old stuff... 2022-01-25 00:12:14 +01:00
Alexandre Aubin
1721516624 Report root services as info instead of warning for Type=oneshot (because these usually are system stuff legitimately running as root) 2021-12-31 02:14:49 +01:00
Alexandre Aubin
e1cea41ae8 Flag set/get of is_public as warning ... is_public is really supposed to be only about initializing the perms ... Also add some advice about no need to temporarily add/remove visitors to the main permission for ynh_local_curl since 4.3 2021-12-05 00:36:29 +01:00
Alexandre Aubin
1a3841070d Lower long-term good quality treshold because some apps are stuck to level 7 just because they were level 0 during a few weeks despite being level 7+ for like two years 2021-12-05 00:19:37 +01:00
Alexandre Aubin
bd6cc2922a Stupid hack to ignore php-pear dependency triggering php_deps warning 2021-12-05 00:18:31 +01:00
Alexandre Aubin
4cee0da0bb Recategorize info as warning for stuff done by 99% of level 7+ apps 2021-12-04 23:54:46 +01:00
Alexandre Aubin
7a2a98a0da Return info instead of warning for bad_final_path_location ... 2021-12-04 19:19:32 +01:00
Alexandre Aubin
084ce4e314 Web applications are supposed to be installed in /var/www/$app, not /opt/ é_è ... 2021-12-04 19:03:08 +01:00
Alexandre Aubin
167f687643 Report deprecated http->https redirect in nginx conf 2021-11-20 22:25:31 +01:00
Alexandre Aubin
5c972a2607 Report config panels version 0.1 2021-11-14 21:36:38 +01:00
Alexandre Aubin
8f6aada99a Deprecated ynh_detect_arch in favor of $YNH_ARCH 2021-11-14 18:21:16 +01:00
Alexandre Aubin
28c515fe5e Report usage of ynh_exec_* and wrapping the command between quotes 2021-11-13 19:24:56 +01:00
Alexandre Aubin
92066d640f Update list of official helpers 2021-11-13 19:05:35 +01:00
Alexandre Aubin
6f44c322fd Add check for deprecated --package option for ynh_add_fpm_config 2021-11-13 19:00:56 +01:00
Sébastien Mennetrier
3056954eb3 Improve check of version in manifest 2021-10-28 15:24:32 +02:00
Sébastien Mennetrier
89969061f0 Udpate some links to documentation 2021-10-28 11:16:41 +02:00
Alexandre Aubin
d4c191c1ca Apply black 2021-10-24 14:33:41 +02:00
Alexandre Aubin
992f491e5e Don't grep doc/ if folder doesn't exist, should prevent some issues 2021-10-24 14:32:15 +02:00
Alexandre Aubin
a3272065dd Report remaining disclaimer placeholders being weird wording @_@ 2021-10-23 17:23:08 +02:00
Alexandre Aubin
1062a8d22e Report unknown-8bit too 2021-10-23 17:05:45 +02:00
Alexandre Aubin
d910c59d76 Aaaannnd I broke everything 2021-10-23 16:59:33 +02:00
Alexandre Aubin
c303c149a0 Report files encoded as latin1 2021-10-23 16:43:22 +02:00
Alexandre Aubin
42c44c31bd Unused weird 'codec' thingy 2021-10-23 16:15:50 +02:00
Alexandre Aubin
6a818a28c5 Aaaaaand typo >_> 2021-10-10 16:39:12 +02:00
Alexandre Aubin
e07d9c5133 Fix false positive warning for path traversal issue 2021-10-10 16:38:01 +02:00
Alexandre Aubin
97f2441cf4 Report usage of install_extra_app_dependencies without --key 2021-10-10 13:39:06 +02:00