Alexandre Aubin
|
a85f6edbf0
|
Recognize display_text as a valid argument type for manifest
|
2020-04-19 00:10:07 +02:00 |
|
Alexandre Aubin
|
e7c24466be
|
No need to start description by is
|
2020-04-11 18:37:50 +02:00 |
|
Alexandre Aubin
|
0e8e5ba043
|
Ugh, path can have spaces -.-
|
2020-04-08 21:24:05 +02:00 |
|
Alexandre Aubin
|
94360abfbc
|
Ugly tricks to avoid 2-3 delay every time its run because of fetching apps.json etc
|
2020-04-08 02:35:03 +02:00 |
|
Alexandre Aubin
|
8439fd0b2e
|
Reorganize some stuff
|
2020-04-08 01:50:29 +02:00 |
|
Alexandre Aubin
|
fcdb15f02d
|
Detect helper sourcing after official ones
|
2020-04-08 01:43:08 +02:00 |
|
Alexandre Aubin
|
dda9bcf5e7
|
Smarter regexes for sed -i subsitutions detections
|
2020-04-03 15:32:30 +02:00 |
|
Alexandre Aubin
|
d34e840d84
|
Path can contain space :s
|
2020-04-03 14:48:45 +02:00 |
|
Alexandre Aubin
|
7095e096bf
|
Keep reporting nginx path traversal as a warning for now ...
|
2020-04-03 04:39:06 +02:00 |
|
Alexandre Aubin
|
98ff1ad323
|
Add note about issue tracker
|
2020-03-31 21:28:38 +02:00 |
|
Alexandre Aubin
|
a9559d7953
|
Do not miserably fail if /conf doesnt exists
|
2020-03-31 21:22:35 +02:00 |
|
Alexandre Aubin
|
d53ee42a7f
|
Check for helpers usage : custom helpers now official, and version requirement not up to date..
|
2020-03-31 21:15:08 +02:00 |
|
Alexandre Aubin
|
4a5d619ad1
|
Do not fail miserably if not able to parse nginx conf
|
2020-03-31 20:06:03 +02:00 |
|
Alexandre Aubin
|
3399c15f73
|
Hack to auto install dependencies if inside a venv
|
2020-03-31 19:17:54 +02:00 |
|
Alexandre Aubin
|
8a62054f34
|
Also report path traversal issue if alias path doesn't use __FINALPATH__
|
2020-03-31 18:45:42 +02:00 |
|
Alexandre Aubin
|
450249197b
|
Promote path traversal issue detection to error instead of warning
|
2020-03-31 18:45:42 +02:00 |
|
Alexandre Aubin
|
16bb33b884
|
Fix path traversal issue detection, the alias folder also needs to end with / for path traversal to happen
|
2020-03-31 18:45:42 +02:00 |
|
Alexandre Aubin
|
acc32c9796
|
Improve path traversal issue detection with proper nginx conf parser
|
2020-03-31 18:45:42 +02:00 |
|
Alexandre Aubin
|
25f9b06517
|
Deprecate yunohost service regen-conf
|
2020-03-31 18:44:50 +02:00 |
|
Alexandre Aubin
|
54e5541a78
|
Let's just get rid of this test that comes from a pretty old era... Not really relevant anymore
|
2020-03-31 05:47:02 +02:00 |
|
Alexandre Aubin
|
7b473212ad
|
Also check _common.sh
|
2020-03-31 05:45:51 +02:00 |
|
Alexandre Aubin
|
bb1eba88bf
|
Be more agressive and report these old helpers as errors.
|
2020-03-31 05:26:03 +02:00 |
|
Alexandre Aubin
|
1c26f84174
|
Be happy and thankful when not even a warning
|
2020-03-31 04:43:48 +02:00 |
|
Alexandre Aubin
|
3ff0e10d11
|
Remove some false negative about ynh_die/exit check
|
2020-03-31 04:31:15 +02:00 |
|
Alexandre Aubin
|
1775202a26
|
Only check for ssowatconf at the end of the file, which is typically where it's useless
|
2020-03-31 04:30:57 +02:00 |
|
Alexandre Aubin
|
73741c225f
|
Allow sudo -u as a legit usage of sudo since ynh_exec_as ain't official
|
2020-03-31 04:30:11 +02:00 |
|
Alexandre Aubin
|
794abd57fd
|
Wording
|
2020-03-31 04:29:12 +02:00 |
|
Alexandre Aubin
|
4d9b1050c3
|
Idk, let's have this just as an info ... seems like not so many people are convinced by this
|
2020-03-31 04:28:53 +02:00 |
|
Alexandre Aubin
|
804bfbd55d
|
Cache license from spdx to avoid a 1-2 sec delay each time it's ran ...
|
2020-03-31 04:27:41 +02:00 |
|
moutonjr
|
4a1a8ef0f2
|
Update package_linter.py
Avoid misunderstandings with error message
Co-Authored-By: Kayou <pierre.moltess@gmail.com>
|
2019-11-05 11:00:47 +01:00 |
|
Moutonjr Geoff
|
d9ea9253b9
|
Adding apps.json new repository paradigm on linter
since YunoHost 3.6 release (https://forum.yunohost.org/t/yunohost-3-6-release-sortie-de-yunohost-3-6/8359),
apps.json is the standard repo for packaging Apps, making YEP1.2 obsolete.
The code has been changed but other documentation and misc must be updated as well,
consider this PR as collaborative.
|
2019-11-04 23:09:03 +01:00 |
|
Alexandre Aubin
|
28f5c5bb10
|
Merge pull request #72 from yalh76/master
adding labriqueinternet as autorized repository
|
2019-05-30 15:33:00 +02:00 |
|
yalh76
|
21ab4c25cb
|
fix ynh_add_extra_apt_repos
|
2019-05-24 14:20:24 +02:00 |
|
yalh76
|
affb4fd693
|
adding labriqueinternet as autorized repository
|
2019-05-22 19:16:12 +02:00 |
|
Alexandre Aubin
|
209e1367c7
|
Merge pull request #70 from YunoHost/improve-sources-list-detection
Improve sources list detection + report messing with sources.list as an error (if not using the helpers)
|
2019-05-03 01:19:24 +02:00 |
|
Alexandre Aubin
|
eec5c67af3
|
Add warning about unecessary use of 'app ssowatconf'
|
2019-04-29 20:23:50 +02:00 |
|
Alexandre Aubin
|
0bdd518046
|
Add check for description which are too long...
|
2019-04-25 23:14:45 +02:00 |
|
Alexandre Aubin
|
729e95fec2
|
Report usage of extra repo / messing up with sources.list as error
|
2019-04-19 17:58:12 +02:00 |
|
Alexandre Aubin
|
c1f328894e
|
Improve detection of apps messing with sources.list
|
2019-04-19 17:42:40 +02:00 |
|
Alexandre Aubin
|
73a1eb528a
|
More gentle warning when failing to parse lines
|
2019-04-19 16:58:57 +02:00 |
|
Kayou
|
f3935cdfaa
|
fix sudo detection
|
2019-04-02 20:57:19 +02:00 |
|
Alexandre Aubin
|
3664802f29
|
Show a warning if 'optional' critera for argument ain't a bool
|
2019-03-27 14:52:10 +01:00 |
|
Alexandre Aubin
|
9181e08814
|
Report "source _common.sh" as warning instead of error
|
2019-03-19 00:10:26 +01:00 |
|
Alexandre Aubin
|
5f2a9101a4
|
Merge branch 'master' into check-custom-apt-source
|
2019-03-18 00:21:45 +01:00 |
|
Alexandre Aubin
|
c4d3b27a21
|
Merge branch 'master' into check-for-path-traversal-issue
|
2019-03-18 00:20:14 +01:00 |
|
Alexandre Aubin
|
f0b497d996
|
Merge pull request #64 from YunoHost/check-required-yunohost-version
Add a warning if required YunoHost version is still 2.x
|
2019-03-18 00:19:41 +01:00 |
|
Alexandre Aubin
|
a343165390
|
Merge pull request #63 from YunoHost/check-for-duplicated-key-in-json
Check for duplicated key in json + empty description
|
2019-03-18 00:19:28 +01:00 |
|
Alexandre Aubin
|
4ce3e0c023
|
Merge pull request #60 from YunoHost/explain-what-ispublic-means
Encourage packagers to detail what is_public means
|
2019-03-18 00:19:10 +01:00 |
|
Alexandre Aubin
|
711312d73b
|
Merge pull request #57 from Mickael-Martin/services_check_manifest
add check service in install file match with manifest (new services)
|
2019-03-18 00:18:55 +01:00 |
|
Alexandre Aubin
|
febac1761c
|
Merge pull request #56 from Mickael-Martin/checksource
Add test of common file
|
2019-03-18 00:18:45 +01:00 |
|
Alexandre Aubin
|
dc2194dfcf
|
Add a warning if required YunoHost version is still 2.x
|
2019-03-09 20:26:30 +01:00 |
|
Alexandre Aubin
|
9867d11ff8
|
Check for duplicated key in json + empty description
|
2019-03-09 19:54:55 +01:00 |
|
Alexandre Aubin
|
f99f2ff5a1
|
Additional check to avoid trying to read binary file in some edge case
|
2019-03-09 19:40:46 +01:00 |
|
Alexandre Aubin
|
af751292ca
|
Check and report usage of custom apt sources
|
2019-03-09 19:36:52 +01:00 |
|
Alexandre Aubin
|
82b715f068
|
Handle case were { is on a newline
|
2019-03-09 19:22:43 +01:00 |
|
Alexandre Aubin
|
fbcdf54cdf
|
Force script order
|
2019-03-09 18:47:48 +01:00 |
|
Alexandre Aubin
|
f6e98894cf
|
Check for path traversal issue
|
2019-03-09 18:38:37 +01:00 |
|
Alexandre Aubin
|
74e60bab86
|
Uhoh not checking the right file
|
2019-03-09 18:35:15 +01:00 |
|
Alexandre Aubin
|
652d6bacb3
|
Encourage packagers to detail what is_public means
|
2019-03-09 17:52:08 +01:00 |
|
Alexandre Aubin
|
ecb7483694
|
Rework check_source_common
|
2019-03-09 17:39:00 +01:00 |
|
Mickael
|
46e6439233
|
add check ./common.sh
cf kay0u ;-)
|
2019-03-09 17:33:35 +01:00 |
|
Mickael
|
9f32e06dcc
|
add test of common file
|
2019-03-09 17:29:44 +01:00 |
|
Mickael
|
02ba265abd
|
add check service in install file match with manifest (new services)
|
2019-03-09 17:15:10 +01:00 |
|
Alexandre Aubin
|
1ccebdbab3
|
check_helper_consistency is now an app method instead of script
|
2019-03-02 02:24:13 +01:00 |
|
Alexandre Aubin
|
1c8bc4abc4
|
Move script checks as method of class Script
|
2019-03-02 02:10:54 +01:00 |
|
Alexandre Aubin
|
6c63667638
|
Rework formatting of multi-line strings
|
2019-03-02 02:06:43 +01:00 |
|
Alexandre Aubin
|
0c4e86d098
|
Move general checks as methods of App class
|
2019-03-02 01:43:29 +01:00 |
|
Alexandre Aubin
|
a0e435c271
|
Move license_mentionned_in_readme inside check_manifest
|
2019-03-02 01:34:44 +01:00 |
|
Alexandre Aubin
|
26c383d0b3
|
check_files_exist -> misc_file_checks and other tweaks
|
2019-03-02 01:30:58 +01:00 |
|
Alexandre Aubin
|
b089229482
|
Begin to factorize script loading in an app class
|
2019-03-02 01:19:40 +01:00 |
|
Alexandre Aubin
|
01085f49fc
|
Rework script parsing : line-per-line (still using shlex)
|
2019-02-23 20:14:56 +01:00 |
|
Alexandre Aubin
|
d0dd509ca2
|
Sometimes there are folders in conf/ ;P
|
2019-02-13 21:17:24 +01:00 |
|
Alexandre Aubin
|
a4844e0924
|
Merge pull request #46 from YunoHost/recommend-ynh-print-info
Recommend ynh_print_info or ynh_script_progression usage in the install script
|
2019-02-13 17:49:56 +01:00 |
|
Alexandre Aubin
|
b27a848203
|
Recommend ynh_print_info or ynh_script_progression usage in the install script
|
2019-02-10 14:12:25 +01:00 |
|
Alexandre Aubin
|
8a5083e858
|
Warn about the use of add_header in nginx conf
|
2019-02-09 16:30:35 +01:00 |
|
Alexandre Aubin
|
daee832af4
|
Report missing argument type as a warning instead of error
|
2019-02-07 19:51:46 +01:00 |
|
Alexandre Aubin
|
af96b17a48
|
Typo
|
2019-02-07 15:55:47 +01:00 |
|
Alexandre Aubin
|
a9c60d39f5
|
Merge branch 'master' into report-arg-type-issues
|
2019-02-07 15:48:29 +01:00 |
|
Alexandre Aubin
|
20a280e2d2
|
print_wrong -> print_error
|
2019-02-07 15:47:38 +01:00 |
|
Alexandre Aubin
|
6bddff93d2
|
Typo
|
2019-02-07 15:06:28 +01:00 |
|
Alexandre Aubin
|
a31bd52de2
|
Fix known service list
|
2019-02-05 17:01:13 +01:00 |
|
Alexandre Aubin
|
247c78c95c
|
Fix broken link
|
2019-01-29 01:42:03 +01:00 |
|
Alexandre Aubin
|
7e4fecf6e6
|
Improve tip about the description
|
2019-01-29 01:36:53 +01:00 |
|
Alexandre Aubin
|
a0c400f946
|
Small tip about the url field in manifest
|
2019-01-29 01:10:12 +01:00 |
|
Alexandre Aubin
|
0587845acb
|
print_wrong -> print_error
|
2019-01-29 00:44:33 +01:00 |
|
Alexandre Aubin
|
657f30a94d
|
Complain if 'yunohost service add' is not matched with a 'yunohost service remove'
|
2019-01-29 00:44:21 +01:00 |
|
Alexandre Aubin
|
171617cb8a
|
Complain about attempts to restart nginx
|
2019-01-29 00:35:23 +01:00 |
|
Alexandre Aubin
|
2e976bcdf3
|
Shlex behavior is fucked up.
|
2019-01-29 00:34:46 +01:00 |
|
Alexandre Aubin
|
fcb9c17edc
|
Big ugly refactoring commit. Boooh. Not cool :|.
|
2019-01-28 23:33:27 +01:00 |
|
Alexandre Aubin
|
5a45d7b7bb
|
Remove commented lines when reading file in raw mode
|
2019-01-28 20:35:07 +01:00 |
|
Alexandre Aubin
|
c7f40ca566
|
Recommend ynh_string_random instead of 'dd' or 'openssl rand'
|
2019-01-28 20:05:38 +01:00 |
|
Alexandre Aubin
|
8060598fed
|
Ugh ... major bug, shlex actually split the whole file in words. If we look for 'rm -rf' occurrences for instances, those are two separate words ... used a raw read instead
|
2019-01-28 20:04:28 +01:00 |
|
Alexandre Aubin
|
910a3b2006
|
Report missing or bad manifest arg type, or unecessary 'choices' usage
|
2019-01-28 19:26:41 +01:00 |
|
Alexandre Aubin
|
f31bebc644
|
Rework and add deprecated helpers usage and deprecated practices
|
2019-01-27 16:32:04 +01:00 |
|
ljf (zamentur)
|
48075f80e3
|
[enh] Check fail if rm -rf
|
2018-12-13 22:48:49 +01:00 |
|
Alexandre Aubin
|
132ee456e0
|
Misc fixes for confusion between full path, script name, and content
|
2018-12-13 20:47:49 +01:00 |
|
Alexandre Aubin
|
29d647ce20
|
Update advice about 'sudo' and others
|
2018-12-02 17:59:45 +01:00 |
|
Alexandre Aubin
|
4a68c76089
|
Use read_file() to get file content without comments
|
2018-12-02 17:56:45 +01:00 |
|
Alexandre Aubin
|
21cb506419
|
Update url for official helpers doc
|
2018-12-02 17:54:54 +01:00 |
|
Jean-Baptiste Holcroft
|
a40342c278
|
Merge branch 'check_ynh_install_app_dependencies' into dependencies_consistency
|
2018-05-27 12:03:26 +02:00 |
|