From d07f162634e5c1f36deacf2a4204b4a52a5cf4ca Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Fri, 1 Feb 2019 15:11:12 +0100 Subject: [PATCH 01/22] Add support for featured apps --- README.md | 26 ++++++++++++++++++++++++++ list_builder.py | 8 +++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 9f0ea44..2bf606b 100644 --- a/README.md +++ b/README.md @@ -40,6 +40,7 @@ sudo yunohost app fetchlist -n community -u https://yunohost.org/community.json * Fork and edit the [community list](https://github.com/YunoHost/apps/tree/master/community.json) * Add your app's ID and git information at the right alphabetical place * Indicate the app's functioning state: `notworking`, `inprogress`, or `working` +* Do not add the level yourself. The CI will do it. * Send a [Pull Request](https://github.com/YunoHost/apps/pulls/) App example addition: @@ -69,5 +70,30 @@ Usage: ./add_or_update.py [community.json OR official.json] [github/gitlab url OR app name [github/gitlab url OR app name [github/gitlab url OR app name ...]]] ``` +### How to make my app a Featured app + +A featured app will be highlighted in the community list as a high quality app. +To become a Featured app, a package have to follow the following rules: + +* The app should already be in the community list for 2 months. +* The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) +* The package itself should be up to date regarding the packaging recommendations and helpers. +* The package should be level 7, at least. +* The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. +* Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. + +If the app is already tag as Featured and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. + +To make an app a Featured app, technically, you have to add the tag ```"featured": true```. +```json + "wallabag": { + "branch": "master", + "featured": true, + "revision": "c2fc62438ac5c9503e3f4ebfdc425ec03a0ec0c0", + "url": "https://github.com/abeudin/wallabag_ynh.git", + "state": "working" + } +``` + #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) diff --git a/list_builder.py b/list_builder.py index 2538718..332ab95 100755 --- a/list_builder.py +++ b/list_builder.py @@ -145,6 +145,7 @@ for app, info in apps_list.items(): app_state = info["state"] app_level = info.get("level") app_maintained = info.get("maintained", True) + app_featured = info.get("featured", False) forge_site = app_url.split('/')[2] owner = app_url.split('/')[3] @@ -167,6 +168,7 @@ for app, info in apps_list.items(): previous_url = already_built_file.get(app, {}).get("git", {}).get("url") previous_level = already_built_file.get(app, {}).get("level") previous_maintained = already_built_file.get(app, {}).get("maintained") + previous_featured = already_built_file.get(app, {}).get("featured") if forge_type == "github" and app_rev == "HEAD": @@ -210,6 +212,9 @@ for app, info in apps_list.items(): if previous_maintained != app_maintained: result_dict[app]["maintained"] = app_maintained print("... but maintained status changed, updating it from '%s' to '%s'" % (previous_maintained, app_maintained)) + if previous_featured != app_featured: + result_dict[app]["featured"] = app_featured + print("... but featured status changed, updating it from '%s' to '%s'" % (previous_featured, app_featured)) print "update translations but don't download anything" result_dict[app]['manifest'] = include_translations_in_manifest(app, result_dict[app]['manifest']) @@ -318,7 +323,8 @@ for app, info in apps_list.items(): 'manifest': include_translations_in_manifest(manifest['id'], manifest), 'state': info['state'], 'level': info.get('level', '?'), - 'maintained': app_maintained + 'maintained': app_maintained, + 'featured': app_featured } except KeyError as e: print("-> Error: invalid app info or manifest, %s" % e) From 8b85136de572a9a6410666648351790ed300a97a Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 17:59:24 +0100 Subject: [PATCH 02/22] Update Featured app and add High Quality ones --- README.md | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 2bf606b..2dd8f1a 100644 --- a/README.md +++ b/README.md @@ -70,10 +70,10 @@ Usage: ./add_or_update.py [community.json OR official.json] [github/gitlab url OR app name [github/gitlab url OR app name [github/gitlab url OR app name ...]]] ``` -### How to make my app a Featured app +### How to make my app a High Quality app ? -A featured app will be highlighted in the community list as a high quality app. -To become a Featured app, a package have to follow the following rules: +A High Quality app will be highlighted in the app list and mark as a level 8 app. +To become a High Quality app, a package have to follow the following rules: * The app should already be in the community list for 2 months. * The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) @@ -82,14 +82,38 @@ To become a Featured app, a package have to follow the following rules: * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. -If the app is already tag as Featured and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. +If the app is already tag as High Quality and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. -To make an app a Featured app, technically, you have to add the tag ```"featured": true```. +To make an app a High Quality app, technically, you have to add the tag ```"high_quality": true```. ```json "wallabag": { "branch": "master", + "high_quality": true, + "revision": HEAD, + "url": "https://github.com/abeudin/wallabag_ynh.git", + "state": "working" + } +``` + +### How to make my app a Featured app ? + +A Featured app highlighted in the app list and shown before any others. +To become a Featured app, a package have to follow the following rules: + +* The app should already be a High Quality app. +* The upstream app should be accessible and well made. +* The app should be interesting and demanded by the community. +* The app should fit the spirit of YunoHost. + +**Please note that the exact process to decide which app are going to be Featured, and for how many time, isn't yet defined...** + +To make an app a High Quality app, technically, you have to add the tag ```"featured": true```. +```json + "wallabag": { + "branch": "master", + "high_quality": true, "featured": true, - "revision": "c2fc62438ac5c9503e3f4ebfdc425ec03a0ec0c0", + "revision": HEAD, "url": "https://github.com/abeudin/wallabag_ynh.git", "state": "working" } From 6b851f13d91276724dad3a77963c8f33e52365cc Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 18:05:20 +0100 Subject: [PATCH 03/22] Add High Quality into the list --- list_builder.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/list_builder.py b/list_builder.py index 332ab95..0790bfb 100755 --- a/list_builder.py +++ b/list_builder.py @@ -146,6 +146,7 @@ for app, info in apps_list.items(): app_level = info.get("level") app_maintained = info.get("maintained", True) app_featured = info.get("featured", False) + app_high_quality = info.get("high_quality", False) forge_site = app_url.split('/')[2] owner = app_url.split('/')[3] @@ -169,6 +170,7 @@ for app, info in apps_list.items(): previous_level = already_built_file.get(app, {}).get("level") previous_maintained = already_built_file.get(app, {}).get("maintained") previous_featured = already_built_file.get(app, {}).get("featured") + previous_high_quality = already_built_file.get(app, {}).get("high_quality") if forge_type == "github" and app_rev == "HEAD": @@ -215,6 +217,9 @@ for app, info in apps_list.items(): if previous_featured != app_featured: result_dict[app]["featured"] = app_featured print("... but featured status changed, updating it from '%s' to '%s'" % (previous_featured, app_featured)) + if previous_high_quality != app_high_quality: + result_dict[app]["high_quality"] = app_high_quality + print("... but high_quality status changed, updating it from '%s' to '%s'" % (previous_high_quality, app_high_quality)) print "update translations but don't download anything" result_dict[app]['manifest'] = include_translations_in_manifest(app, result_dict[app]['manifest']) @@ -324,6 +329,7 @@ for app, info in apps_list.items(): 'state': info['state'], 'level': info.get('level', '?'), 'maintained': app_maintained, + 'high_quality': app_high_quality, 'featured': app_featured } except KeyError as e: From 3f499d58e3cf95c92f189a5ea7b4ced6d9dedd4a Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 18:12:18 +0100 Subject: [PATCH 04/22] Typo fix --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2dd8f1a..c11c095 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ To become a Featured app, a package have to follow the following rules: **Please note that the exact process to decide which app are going to be Featured, and for how many time, isn't yet defined...** -To make an app a High Quality app, technically, you have to add the tag ```"featured": true```. +To make an app a Featured app, technically, you have to add the tag ```"featured": true```. ```json "wallabag": { "branch": "master", From ceaa6262913c15d64ef3b402e68fab901dd4d706 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Thu, 21 Feb 2019 01:26:04 +0100 Subject: [PATCH 05/22] Add info about maintained status --- README.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/README.md b/README.md index c11c095..e542c86 100644 --- a/README.md +++ b/README.md @@ -119,5 +119,18 @@ To make an app a Featured app, technically, you have to add the tag ```"featured } ``` +### What to do if I can't maintain my app anymore ? + +If you don't have time anymore to maintain an app, you can update its status to inform users and packagers that you will not maintain it anymore. +In order to do so, use the tag `"maintained":`. +This tag can have 5 different values: +- `"maintained": true` That's the default value if the tag isn't present for your app. That simply means that this app is maintained. +- `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. +- `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. +- `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself as its new maintainer. +Please contact Apps group if you want to take back a unmaintained app. + +If you want to modify the status of one of your app, for any reason, please think also to inform the community via the forum. Users would probably be glad to be inform that an app they use will be unmaintained. + #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) From ca97b6f888270f0a57cfa804bf18553c92e209fb Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 4 Mar 2019 19:43:38 +0100 Subject: [PATCH 06/22] Add info about level 8 and validation template --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index e542c86..19840a0 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,9 @@ To become a High Quality app, a package have to follow the following rules: * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. +* The package should comply with the [requirement of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). + +You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). If the app is already tag as High Quality and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. From 349337c0207d379b2b8ed6880be7f129012bf7df Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:12:31 +0100 Subject: [PATCH 07/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 19840a0..f77750f 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,7 @@ Usage: ### How to make my app a High Quality app ? -A High Quality app will be highlighted in the app list and mark as a level 8 app. +A High Quality app will be highlighted in the app list and marked as a level 8 app. To become a High Quality app, a package have to follow the following rules: * The app should already be in the community list for 2 months. From f8b75f32825cc77c505f8eb88c5d7d8c62e6f465 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:12:41 +0100 Subject: [PATCH 08/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f77750f..a3c6361 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,7 @@ Usage: ### How to make my app a High Quality app ? A High Quality app will be highlighted in the app list and marked as a level 8 app. -To become a High Quality app, a package have to follow the following rules: +To become a High Quality app, a package has to follow the following rules: * The app should already be in the community list for 2 months. * The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) From 617653952b89ef1308142bbf191438958bd920fc Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:12:54 +0100 Subject: [PATCH 09/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a3c6361..743c9df 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ Usage: A High Quality app will be highlighted in the app list and marked as a level 8 app. To become a High Quality app, a package has to follow the following rules: -* The app should already be in the community list for 2 months. +* The app should already have been in the community list for 2 months. * The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) * The package itself should be up to date regarding the packaging recommendations and helpers. * The package should be level 7, at least. From 0298ba0fe967f2a3c16a6ec5c6b0fefcddab2466 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:13:11 +0100 Subject: [PATCH 10/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 743c9df..dddd084 100644 --- a/README.md +++ b/README.md @@ -76,7 +76,7 @@ A High Quality app will be highlighted in the app list and marked as a level 8 a To become a High Quality app, a package has to follow the following rules: * The app should already have been in the community list for 2 months. -* The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) +* The app should be kept up to date, regarding the upstream source (if it’s possible with our current YunoHost version). * The package itself should be up to date regarding the packaging recommendations and helpers. * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. From bbd8c1d3332dec5f5e69df668ea061102613dfef Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:13:38 +0100 Subject: [PATCH 11/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index dddd084..5563eaf 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ To become a High Quality app, a package has to follow the following rules: * The package itself should be up to date regarding the packaging recommendations and helpers. * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. -* Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. +* Any modification should be done to the testing branch, and wait at least for one approval of one member of the Apps group so that we can ensure that there’s nothing in opposition to those criteria, nor any changes that would harm servers. * The package should comply with the [requirement of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). From d472853f30fde65334377c87e6abc0b6a548e2e7 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:14:31 +0100 Subject: [PATCH 12/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5563eaf..0357d52 100644 --- a/README.md +++ b/README.md @@ -133,7 +133,7 @@ This tag can have 5 different values: - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself as its new maintainer. Please contact Apps group if you want to take back a unmaintained app. -If you want to modify the status of one of your app, for any reason, please think also to inform the community via the forum. Users would probably be glad to be inform that an app they use will be unmaintained. +If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) From 980ed7e1cd36e6553eedff30fa27b01c343b7d48 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:16:22 +0100 Subject: [PATCH 13/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0357d52..2f91856 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ To become a High Quality app, a package has to follow the following rules: * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval of one member of the Apps group so that we can ensure that there’s nothing in opposition to those criteria, nor any changes that would harm servers. -* The package should comply with the [requirement of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). +* The package should comply with the [requirements of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). From 9870174cc6c5477b63ff2297a422dec1f5f41255 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:17:40 +0100 Subject: [PATCH 14/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2f91856..efa559b 100644 --- a/README.md +++ b/README.md @@ -100,7 +100,7 @@ To make an app a High Quality app, technically, you have to add the tag ```"high ### How to make my app a Featured app ? -A Featured app highlighted in the app list and shown before any others. +A Featured app is highlighted in the app list and shown before any others. To become a Featured app, a package have to follow the following rules: * The app should already be a High Quality app. From b425ed46fbecad67112632473b7b926783a383d0 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:18:01 +0100 Subject: [PATCH 15/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index efa559b..7290c01 100644 --- a/README.md +++ b/README.md @@ -101,7 +101,7 @@ To make an app a High Quality app, technically, you have to add the tag ```"high ### How to make my app a Featured app ? A Featured app is highlighted in the app list and shown before any others. -To become a Featured app, a package have to follow the following rules: +To become a Featured app, a package has to follow the following rules: * The app should already be a High Quality app. * The upstream app should be accessible and well made. From 76f5e856a1a7e3f51a9c6ce369fbeaa742569ea8 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:18:27 +0100 Subject: [PATCH 16/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7290c01..7f25bd5 100644 --- a/README.md +++ b/README.md @@ -108,7 +108,7 @@ To become a Featured app, a package has to follow the following rules: * The app should be interesting and demanded by the community. * The app should fit the spirit of YunoHost. -**Please note that the exact process to decide which app are going to be Featured, and for how many time, isn't yet defined...** +**Please note that the exact process to decide which apps are going to be Featured, and for how many time, isn't yet defined...** To make an app a Featured app, technically, you have to add the tag ```"featured": true```. ```json From cf07763577105785a94a0384009d5ff107a49e3d Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:20:44 +0100 Subject: [PATCH 17/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7f25bd5..e12808d 100644 --- a/README.md +++ b/README.md @@ -130,7 +130,7 @@ This tag can have 5 different values: - `"maintained": true` That's the default value if the tag isn't present for your app. That simply means that this app is maintained. - `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. - `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. -- `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself as its new maintainer. +- `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. Please contact Apps group if you want to take back a unmaintained app. If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. From e3aa4e060093dbf0554995a3736820cb1cd94b10 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:20:55 +0100 Subject: [PATCH 18/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e12808d..82f8fcb 100644 --- a/README.md +++ b/README.md @@ -131,7 +131,7 @@ This tag can have 5 different values: - `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. - `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. -Please contact Apps group if you want to take back a unmaintained app. +Please contact Apps group if you want to take back an unmaintained app. If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. From de130d0b03b3c971812e8eaad4e44858729bff85 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 19:33:14 +0100 Subject: [PATCH 19/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 82f8fcb..38f9f5d 100644 --- a/README.md +++ b/README.md @@ -85,7 +85,7 @@ To become a High Quality app, a package has to follow the following rules: You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). -If the app is already tag as High Quality and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. +If the app is already tagged as High Quality and one of those criteria isn't respected anymore: after a warning, the tag will be removed until the criterion is again validated. To make an app a High Quality app, technically, you have to add the tag ```"high_quality": true```. ```json From a1865f614b2a5ec0021eb5548de79542ffac0f3a Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 20:13:57 +0100 Subject: [PATCH 20/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 38f9f5d..b1fa37e 100644 --- a/README.md +++ b/README.md @@ -131,7 +131,7 @@ This tag can have 5 different values: - `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. - `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. -Please contact Apps group if you want to take back an unmaintained app. +Please contact the Apps group if you want to take care of an unmaintained app. If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. From a8e5deee1eb7ade8586e1c725d687e3b7228c1a7 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 20:14:16 +0100 Subject: [PATCH 21/22] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b1fa37e..e43402e 100644 --- a/README.md +++ b/README.md @@ -133,7 +133,7 @@ This tag can have 5 different values: - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. Please contact the Apps group if you want to take care of an unmaintained app. -If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. +If you want to modify the status of one of your apps, for any reason, please consider informing the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) From 785f091596e262e0414eeeac170918db1124e897 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Tue, 12 Mar 2019 19:06:56 +0100 Subject: [PATCH 22/22] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e43402e..56afc79 100644 --- a/README.md +++ b/README.md @@ -78,7 +78,7 @@ To become a High Quality app, a package has to follow the following rules: * The app should already have been in the community list for 2 months. * The app should be kept up to date, regarding the upstream source (if it’s possible with our current YunoHost version). * The package itself should be up to date regarding the packaging recommendations and helpers. -* The package should be level 7, at least. +* The package should be level 7 for at least 1 month. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval of one member of the Apps group so that we can ensure that there’s nothing in opposition to those criteria, nor any changes that would harm servers. * The package should comply with the [requirements of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8).