From 25482b67caae86b3dbe76f686371eee897ded819 Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Sat, 6 Jul 2024 15:57:47 +0200
Subject: [PATCH] refactor: add useInitialQueries composable to replace
 ViewBase queries handling

---
 app/src/components/globals/ViewBase.vue  | 64 +++++-------------------
 app/src/composables/useInitialQueries.ts | 41 +++++++++++++++
 2 files changed, 53 insertions(+), 52 deletions(-)
 create mode 100644 app/src/composables/useInitialQueries.ts

diff --git a/app/src/components/globals/ViewBase.vue b/app/src/components/globals/ViewBase.vue
index e30138e5..ca870c6b 100644
--- a/app/src/components/globals/ViewBase.vue
+++ b/app/src/components/globals/ViewBase.vue
@@ -1,22 +1,15 @@
 <script setup lang="ts">
 import type { Component } from 'vue'
-import { computed, ref } from 'vue'
 
-import api from '@/api'
-
-// FIXME type queries
-const props = withDefaults(
+defineOptions({ inheritAttrs: false })
+withDefaults(
   defineProps<{
-    queries?: any[]
-    queriesWait?: boolean
-    skeleton?: string | Component
     loading?: boolean
+    skeleton?: string | Component
   }>(),
   {
-    queries: undefined,
-    queriesWait: false,
-    skeleton: undefined,
-    loading: undefined,
+    loading: false,
+    skeleton: 'CardFormSkeleton',
   },
 )
 
@@ -24,44 +17,11 @@ const slots = defineSlots<{
   'top-bar-group-left': any
   'top-bar-group-right': any
   'top-bar': any
-  top(props: { loading: boolean }): any
-  default(props: { loading: boolean }): any
-  bot(props: { loading: boolean }): any
+  top: any
+  default: any
+  bot: any
   skeleton: any
 }>()
-
-const emit = defineEmits<{
-  'queries-response': any[]
-}>()
-
-defineExpose({ fetchQueries })
-
-const fallbackLoading = ref(
-  props.loading === undefined && props.queries !== undefined ? true : null,
-)
-
-const isLoading = computed(() => {
-  if (props.loading !== undefined) return props.loading
-  return fallbackLoading.value
-})
-
-function fetchQueries({ triggerLoading = false } = {}) {
-  if (triggerLoading) {
-    fallbackLoading.value = true
-  }
-
-  return api
-    .fetchAll(props.queries, { wait: props.queriesWait, initial: true })
-    .then((responses) => {
-      emit('queries-response', ...responses)
-      fallbackLoading.value = false
-      return responses
-    })
-}
-
-if (props.queries) {
-  fetchQueries()
-}
 </script>
 
 <template>
@@ -76,9 +36,9 @@ if (props.queries) {
     </TopBar>
     <slot v-else name="top-bar" />
 
-    <slot name="top" v-bind="{ loading: isLoading }" />
+    <slot name="top" />
 
-    <BSkeletonWrapper :loading="isLoading">
+    <BSkeletonWrapper :loading="loading">
       <template #loading>
         <slot name="skeleton">
           <Component :is="skeleton" />
@@ -87,10 +47,10 @@ if (props.queries) {
 
       <!-- Empty div to be able to receive multiple components -->
       <div>
-        <slot name="default" v-bind="{ loading: isLoading }" />
+        <slot name="default" />
       </div>
     </BSkeletonWrapper>
 
-    <slot name="bot" v-bind="{ loading: isLoading }" />
+    <slot name="bot" />
   </div>
 </template>
diff --git a/app/src/composables/useInitialQueries.ts b/app/src/composables/useInitialQueries.ts
new file mode 100644
index 00000000..b116a1bb
--- /dev/null
+++ b/app/src/composables/useInitialQueries.ts
@@ -0,0 +1,41 @@
+import type { ComputedRef, MaybeRefOrGetter, Ref } from 'vue'
+import { ref, toValue } from 'vue'
+
+import type { APIQuery } from '@/api/api'
+import api from '@/api/api'
+import type { Obj } from '@/types/commons'
+
+export function useInitialQueries<
+  ResponsesType extends (Obj | string)[] = Obj[],
+>(
+  queries: MaybeRefOrGetter<APIQuery[]> | ComputedRef<APIQuery[]>,
+  {
+    onQueriesResponse,
+    wait = false,
+  }: {
+    onQueriesResponse?: (...responses: ResponsesType) => Promise<void> | void
+    wait?: boolean
+  } = {},
+) {
+  const loading = ref(true)
+  const responses: Ref<ResponsesType | null> = ref(null)
+  // FIXME watch `queries` to call on change?
+
+  function call(triggerLoading = true) {
+    if (triggerLoading) loading.value = true
+    return api
+      .fetchAll(toValue(queries), { wait, initial: true })
+      .then(async (responses_) => {
+        responses.value = responses_ as ResponsesType
+        if (onQueriesResponse) {
+          await onQueriesResponse(...(responses_ as ResponsesType))
+        }
+        loading.value = false
+        return responses
+      })
+  }
+
+  call()
+
+  return { loading, responses, refetch: call }
+}