From 372942d5e3f3a59406c64bacdcb094a9e32ecb99 Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Tue, 18 Oct 2022 18:13:42 +0200
Subject: [PATCH] appactions: rm old app action route + view

---
 app/src/i18n/locales/en.json     |   4 --
 app/src/router/routes.js         |  10 ---
 app/src/views/app/AppActions.vue | 106 -------------------------------
 app/src/views/app/AppInfo.vue    |  15 +----
 4 files changed, 1 insertion(+), 134 deletions(-)
 delete mode 100644 app/src/views/app/AppActions.vue

diff --git a/app/src/i18n/locales/en.json b/app/src/i18n/locales/en.json
index 05b8bd5e..4ec1499a 100644
--- a/app/src/i18n/locales/en.json
+++ b/app/src/i18n/locales/en.json
@@ -54,8 +54,6 @@
     "api_not_found": "Seems like the web-admin tried to query something that doesn't exist.",
     "api_not_responding": "The YunoHost API is not responding. Maybe 'yunohost-api' is down or got restarted?",
     "api_waiting": "Waiting for the server's response...",
-    "app_actions": "Actions",
-    "app_actions_label": "Perform actions",
     "app_choose_category": "Choose a category",
     "app_config_panel": "Config panel",
     "app_config_panel_label": "Configure this app",
@@ -69,7 +67,6 @@
     "app_install_parameters": "Install settings",
     "app_manage_label_and_tiles": "Manage label and tiles",
     "app_make_default": "Make default",
-    "app_no_actions": "This application doesn't have any actions",
     "app_show_categories": "Show categories",
     "app_state_inprogress": "not yet working",
     "app_state_inprogress_explanation": "This maintainer of this app declared that this application is not ready yet for production use. BE CAREFUL!",
@@ -407,7 +404,6 @@
           "change_url": "Change access URL of '{name}'",
           "install": "Install app '{name}'",
           "set_default": "Redirect '{domain}' domain root to '{name}'",
-          "perform_action": "Perform action '{action}' of app '{name}'",
           "uninstall": "Uninstall app '{name}'",
           "update_config": "Update panel '{id}' of app '{name}' configuration"
         },
diff --git a/app/src/router/routes.js b/app/src/router/routes.js
index 0cddd8f7..7d815851 100644
--- a/app/src/router/routes.js
+++ b/app/src/router/routes.js
@@ -210,16 +210,6 @@ const routes = [
       breadcrumb: ['app-list', 'app-info']
     }
   },
-  {
-    name: 'app-actions',
-    path: '/apps/:id/actions',
-    component: () => import(/* webpackChunkName: "views/apps/actions" */ '@/views/app/AppActions'),
-    props: true,
-    meta: {
-      args: { trad: 'app_actions' },
-      breadcrumb: ['app-list', 'app-info', 'app-actions']
-    }
-  },
   {
     // no need for name here, only children are visited
     path: '/apps/:id/config-panel',
diff --git a/app/src/views/app/AppActions.vue b/app/src/views/app/AppActions.vue
deleted file mode 100644
index 6a92dded..00000000
--- a/app/src/views/app/AppActions.vue
+++ /dev/null
@@ -1,106 +0,0 @@
-<template>
-  <view-base
-    :queries="queries" @queries-response="onQueriesResponse"
-    ref="view" skeleton="card-form-skeleton"
-  >
-    <template v-if="actions" #default>
-      <b-alert variant="warning" class="mb-4">
-        <icon iname="exclamation-triangle" /> {{ $t('experimental_warning') }}
-      </b-alert>
-
-      <!-- ACTIONS FORMS -->
-      <card-form
-        v-for="(action, i) in actions" :key="i"
-        :title="action.name" icon="wrench" title-tag="h4"
-        :validation="$v.actions[i]" :id="action.id + '-form'" :server-error="action.serverError"
-        @submit.prevent="performAction(action)" :submit-text="$t('perform')"
-      >
-        <form-field
-          v-for="(field, fname) in action.fields" :key="fname" label-cols="0"
-          v-bind="field" v-model="action.form[fname]" :validation="$v.actions[i][fname]"
-        />
-      </card-form>
-    </template>
-
-    <!-- In case of a custom url with no manifest found -->
-    <b-alert v-else-if="actions === null" variant="warning">
-      <icon iname="exclamation-triangle" /> {{ $t('app_no_actions') }}
-    </b-alert>
-  </view-base>
-</template>
-
-<script>
-import api, { objectToParams } from '@/api'
-import { validationMixin } from 'vuelidate'
-
-import { formatI18nField, formatYunoHostArguments, formatFormData } from '@/helpers/yunohostArguments'
-
-export default {
-  name: 'AppActions',
-
-  mixins: [validationMixin],
-
-  props: {
-    id: { type: String, required: true }
-  },
-
-  data () {
-    return {
-      queries: [
-        ['GET', `apps/${this.id}/actions`],
-        ['GET', { uri: 'domains' }],
-        ['GET', { uri: 'domains/main', storeKey: 'main_domain' }],
-        ['GET', { uri: 'users' }]
-      ],
-      actions: undefined
-    }
-  },
-
-  validations () {
-    const validations = {}
-    for (const [i, action] of this.actions.entries()) {
-      if (action.validations) {
-        validations[i] = { form: action.validations }
-      }
-    }
-    return { actions: validations }
-  },
-
-  methods: {
-    onQueriesResponse (data) {
-      if (!data.actions) {
-        this.actions = null
-        return
-      }
-
-      this.actions = data.actions.map(({ name, id, description, arguments: arguments_ }) => {
-        const action = { name, id, serverError: '' }
-        if (description) action.description = formatI18nField(description)
-        if (arguments_ && arguments_.length) {
-          const { form, fields, validations } = formatYunoHostArguments(arguments_)
-          action.form = form
-          action.fields = fields
-          if (validations) action.validations = validations
-        }
-        return action
-      })
-    },
-
-    performAction (action) {
-      // FIXME api expects at least one argument ?! (fake one given with { dontmindthis } )
-      const args = objectToParams(action.form ? formatFormData(action.form) : { dontmindthis: undefined })
-
-      api.put(
-        `apps/${this.id}/actions/${action.id}`,
-        { args },
-        { key: 'apps.perform_action', action: action.id, name: this.id }
-      ).then(() => {
-        this.$refs.view.fetchQueries()
-      }).catch(err => {
-        if (err.name !== 'APIBadRequestError') throw err
-        action.serverError = err.message
-      })
-    }
-  }
-}
-</script>
diff --git a/app/src/views/app/AppInfo.vue b/app/src/views/app/AppInfo.vue
index 55cc758c..19727b7b 100644
--- a/app/src/views/app/AppInfo.vue
+++ b/app/src/views/app/AppInfo.vue
@@ -134,19 +134,6 @@
       </b-form-group>
     </card>
 
-    <!-- EXPERIMENTAL (displayed if experimental feature has been enabled in web-admin options)-->
-    <card v-if="experimental" :title="$t('experimental')" icon="flask">
-      <!-- APP ACTIONS -->
-      <b-form-group
-        :label="$t('app_actions_label')" label-for="actions"
-        label-cols-md="4" label-class="font-weight-bold"
-      >
-        <b-button id="actions" variant="warning" :to="{ name: 'app-actions', params: { id } }">
-          <icon iname="flask" /> {{ $t('app_actions') }}
-        </b-button>
-      </b-form-group>
-    </card>
-
     <template #skeleton>
       <card-info-skeleton :item-count="8" />
       <card-form-skeleton />
@@ -184,7 +171,7 @@ export default {
   },
 
   computed: {
-    ...mapGetters(['domains', 'experimental']),
+    ...mapGetters(['domains']),
 
     allowedGroups () {
       if (!this.app) return