From 5cd0ed23a564e9adec7decaeca53b706f46c916a Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Fri, 5 Jul 2024 17:03:55 +0200
Subject: [PATCH] refactor: CheckboxItem typing

---
 .../globals/formItems/CheckboxItem.vue        | 30 ++++++++++++-------
 app/src/types/form.ts                         |  7 +++++
 2 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/app/src/components/globals/formItems/CheckboxItem.vue b/app/src/components/globals/formItems/CheckboxItem.vue
index 01a464c7..51d53d7a 100644
--- a/app/src/components/globals/formItems/CheckboxItem.vue
+++ b/app/src/components/globals/formItems/CheckboxItem.vue
@@ -1,31 +1,39 @@
 <script setup lang="ts">
+import type { CheckboxItemProps, BaseItemComputedProps } from '@/types/form'
+
 withDefaults(
-  defineProps<{
-    modelValue: boolean
-    id?: string
-    label?: string
-    labels?: { true: string; false: string }
-  }>(),
+  defineProps<CheckboxItemProps & BaseItemComputedProps<boolean>>(),
   {
     id: undefined,
+    name: undefined,
+    placeholder: undefined,
+    touchKey: undefined,
     label: undefined,
     labels: () => ({ true: 'yes', false: 'no' }),
+
+    ariaDescribedby: undefined,
+    modelValue: undefined,
+    state: undefined,
+    validation: undefined,
   },
 )
 
-const emit = defineEmits<{
+defineEmits<{
   'update:modelValue': [value: boolean]
 }>()
+
+const model = defineModel<boolean>()
 </script>
 
 <template>
   <BFormCheckbox
-    :modelValue="modelValue"
-    @update:modelValue="emit('update:modelValue', $event)"
     :id="id"
-    :aria-describedby="$parent.id + '__BV_description_'"
+    v-model="model"
+    :name="name"
+    :aria-describedby="ariaDescribedby"
+    :state="state"
     switch
   >
-    {{ label || $t(labels[modelValue]) }}
+    {{ label || $t(labels[modelValue ? 'true' : 'false']) }}
   </BFormCheckbox>
 </template>
diff --git a/app/src/types/form.ts b/app/src/types/form.ts
index 0ac585ad..9c06af0a 100644
--- a/app/src/types/form.ts
+++ b/app/src/types/form.ts
@@ -26,3 +26,10 @@ export type AdressModelValue = {
   separator: string
   domain: string | null
 }
+
+export type CheckboxItemProps = BaseWritableItemProps & {
+  label?: string
+  labels?: { true: string; false: string }
+  // FIXME unused?
+  // choices: string[]
+}