From 75925a203b03983663e1333fdc1247222cfd1052 Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Fri, 23 Aug 2024 14:00:14 +0200
Subject: [PATCH] chore: rm some FIXME

---
 app/src/components/globals/skeletons/BSkeletonWrapper.vue | 1 -
 app/src/components/layouts/MainLayout.vue                 | 1 -
 app/src/components/modals/ModalReconnecting.vue           | 1 -
 app/src/composables/configPanels.ts                       | 2 --
 app/src/types/form.ts                                     | 1 -
 app/src/views/PostInstall.vue                             | 2 --
 app/src/views/backup/BackupCreate.vue                     | 1 -
 app/src/views/domain/DomainList.vue                       | 1 -
 app/src/views/group/GroupList.vue                         | 1 -
 app/src/views/tool/ToolList.vue                           | 1 -
 10 files changed, 12 deletions(-)

diff --git a/app/src/components/globals/skeletons/BSkeletonWrapper.vue b/app/src/components/globals/skeletons/BSkeletonWrapper.vue
index e2200d83..e579b41b 100644
--- a/app/src/components/globals/skeletons/BSkeletonWrapper.vue
+++ b/app/src/components/globals/skeletons/BSkeletonWrapper.vue
@@ -12,7 +12,6 @@ defineSlots<{
 <template>
   <div class="y-skeleton-wrapper">
     <div class="visually-hidden">
-      <!-- FIXME add `loading` translation -->
       {{ $t('loading') }}
     </div>
 
diff --git a/app/src/components/layouts/MainLayout.vue b/app/src/components/layouts/MainLayout.vue
index 91e4258c..730fa78c 100644
--- a/app/src/components/layouts/MainLayout.vue
+++ b/app/src/components/layouts/MainLayout.vue
@@ -106,7 +106,6 @@ const modalComponent = computed(() => {
       class="ms-auto"
     >
       <template #button-content>
-        <!-- FIXME i18n `quick_add` -->
         <YIcon iname="plus" /> {{ t('quick_add') }}
       </template>
       <template v-for="(item, i) in quickAddItems" :key="i">
diff --git a/app/src/components/modals/ModalReconnecting.vue b/app/src/components/modals/ModalReconnecting.vue
index 0ee3a37b..3f15e7c8 100644
--- a/app/src/components/modals/ModalReconnecting.vue
+++ b/app/src/components/modals/ModalReconnecting.vue
@@ -20,7 +20,6 @@ const request = reactive<{
   subStatus?: 'expired' | 'failed'
 }>({
   status: 'pending',
-  // FIXME translate
   humanRoute: 'reconnecting',
 })
 
diff --git a/app/src/composables/configPanels.ts b/app/src/composables/configPanels.ts
index e31d7e83..f2639404 100644
--- a/app/src/composables/configPanels.ts
+++ b/app/src/composables/configPanels.ts
@@ -234,7 +234,6 @@ export function formatOptions<MV extends Obj>(
   fields: FormFieldDict<MV>
   form: Ref<MV>
 } {
-  // FIXME handle optional for app install ? or is already handled in core bookworm?
   const form = ref(
     Object.fromEntries(
       options
@@ -332,7 +331,6 @@ function useExpression(
     // FIXME normalize expression in core? ('', 'false', 'true') and rm next 2 lines
     if (!expression || expression === 'true') return true
     if (expression === 'false') return false
-    // FIXME remove asUnreffed and manage ref type?
     return useEvaluation(expression, form)
   }
   return true
diff --git a/app/src/types/form.ts b/app/src/types/form.ts
index 89c07d97..ca11ae66 100644
--- a/app/src/types/form.ts
+++ b/app/src/types/form.ts
@@ -27,7 +27,6 @@ type BaseDisplayItemProps = {
 }
 
 export type ButtonItemProps = BaseDisplayItemProps & {
-  // FIXME compute enabled JSExpression
   id: string
   enabled?: boolean | ComputedRef<boolean>
   icon?: string
diff --git a/app/src/views/PostInstall.vue b/app/src/views/PostInstall.vue
index 5e85602a..fc170a3a 100644
--- a/app/src/views/PostInstall.vue
+++ b/app/src/views/PostInstall.vue
@@ -42,7 +42,6 @@ const form = ref({
   confirmation: '',
 })
 const fields = {
-  // FIXME satisfies FormFieldDict but not for CardForm?
   alert: {
     component: 'ReadOnlyAlertItem',
     cProps: { label: t('postinstall.user.first_user_help'), type: 'info' },
@@ -119,7 +118,6 @@ async function performPostInstall(force = false) {
     { removeEmpty: true },
   )
 
-  // FIXME does the api will throw an error for bad passwords ?
   api
     .post({
       uri: 'postinstall' + (force ? '?force_diskspace' : ''),
diff --git a/app/src/views/backup/BackupCreate.vue b/app/src/views/backup/BackupCreate.vue
index d313072b..4d124b0f 100644
--- a/app/src/views/backup/BackupCreate.vue
+++ b/app/src/views/backup/BackupCreate.vue
@@ -86,7 +86,6 @@ const CheckboxList = createReusableTemplate<{
         :key="partName"
         class="d-flex justify-content-between align-items-center pe-0"
       >
-        <!-- FIXME use FormField or BFormGroup to get labels? -->
         <div class="me-2">
           <h5 v-if="'id' in item">
             <span class="fw-bold me-1">{{ item.name }}</span>
diff --git a/app/src/views/domain/DomainList.vue b/app/src/views/domain/DomainList.vue
index 9d8e10c6..cb09ba49 100644
--- a/app/src/views/domain/DomainList.vue
+++ b/app/src/views/domain/DomainList.vue
@@ -33,7 +33,6 @@ const [search, filteredTree] = useSearch(domainsTree, (s, node) =>
       :toggle-text="$t('domain.toggle_subdomains')"
       class="mb-5"
     >
-      <!-- FIXME slot typing not appearing? -->
       <template #default="{ data, parent }">
         <div class="w-100 d-flex justify-content-between align-items-center">
           <h5 class="me-3">
diff --git a/app/src/views/group/GroupList.vue b/app/src/views/group/GroupList.vue
index 18b02c83..328a299f 100644
--- a/app/src/views/group/GroupList.vue
+++ b/app/src/views/group/GroupList.vue
@@ -143,7 +143,6 @@ async function deleteGroup(name: string) {
       humanKey: { key: 'groups.delete', name },
     })
     .then(() => {
-      // FIXME primaryGroups as ref to override it ?
       primaryGroups.value = primaryGroups.value.filter(
         (group) => group.name !== name,
       )
diff --git a/app/src/views/tool/ToolList.vue b/app/src/views/tool/ToolList.vue
index 7f970d6e..dbcf9fe5 100644
--- a/app/src/views/tool/ToolList.vue
+++ b/app/src/views/tool/ToolList.vue
@@ -26,7 +26,6 @@ const menu = [
 ]
 </script>
 
-<!-- FIXME make a component shared with HomeView.vue ? -->
 <template>
   <BListGroup class="menu-list">
     <BListGroupItem