From 8273b528981572cf5c47fb71280d36b658ec9535 Mon Sep 17 00:00:00 2001
From: Axolotle <nchesnais@mailoo.org>
Date: Sat, 9 Jan 2021 13:02:26 +0100
Subject: [PATCH] linting

---
 app/package.json                      |  2 +-
 app/src/api/handlers.js               |  4 +---
 app/src/components/BaseSelectize.vue  |  2 +-
 app/src/views/app/AppCatalog.vue      | 21 ++++++++++-----------
 app/src/views/backup/BackupList.vue   | 12 ++++++++----
 app/src/views/diagnosis/Diagnosis.vue |  2 +-
 6 files changed, 22 insertions(+), 21 deletions(-)

diff --git a/app/package.json b/app/package.json
index 5d5b3b87..839343e1 100644
--- a/app/package.json
+++ b/app/package.json
@@ -7,7 +7,7 @@
   "scripts": {
     "serve": "vue-cli-service serve",
     "build": "vue-cli-service build",
-    "lint": "vue-cli-service lint",
+    "lint": "vue-cli-service lint --no-fix",
     "i18n": "vue-cli-service i18n:report --src './src/**/*.?(js|vue)' --locales './src/i18n/locales/*.json'",
     "i18n:en": "vue-cli-service i18n:report --src './src/**/*.?(js|vue)' --locales './src/i18n/locales/en.json'"
   },
diff --git a/app/src/api/handlers.js b/app/src/api/handlers.js
index 165f7b8b..8efe146a 100644
--- a/app/src/api/handlers.js
+++ b/app/src/api/handlers.js
@@ -54,7 +54,7 @@ export async function handleError (response, method) {
     store.dispatch('DISCONNECT')
   } else if (error.code === 400) {
     if (typeof message !== 'string' && 'log_ref' in message) {
-        router.push({ name: 'tool-log', params: { name: message.log_ref } })
+      router.push({ name: 'tool-log', params: { name: message.log_ref } })
     }
     // Hide the waiting screen
     store.dispatch('SERVER_RESPONDED', true)
@@ -62,7 +62,5 @@ export async function handleError (response, method) {
     store.dispatch('DISPATCH_ERROR', error)
   }
 
-  // error.print()
-
   throw error
 }
diff --git a/app/src/components/BaseSelectize.vue b/app/src/components/BaseSelectize.vue
index 89404403..5dc6a7ce 100644
--- a/app/src/components/BaseSelectize.vue
+++ b/app/src/components/BaseSelectize.vue
@@ -1,4 +1,4 @@
-<template lang="html">
+<template>
   <div class="selectize-base">
     <b-input-group>
       <b-input-group-prepend is-text>
diff --git a/app/src/views/app/AppCatalog.vue b/app/src/views/app/AppCatalog.vue
index ddc3d0e7..acd0f0b2 100644
--- a/app/src/views/app/AppCatalog.vue
+++ b/app/src/views/app/AppCatalog.vue
@@ -132,16 +132,16 @@
           v-for="i in 15" :key="i"
           no-body style="min-height: 10rem;"
         >
-        <div class="d-flex w-100 mt-auto">
-          <b-skeleton width="30px" height="30px" class="mr-2 ml-auto" />
-          <b-skeleton :width="randint(30, 70) + '%'" height="30px" class="mr-auto" />
-        </div>
-        <b-skeleton
-          v-if="randint(0, 1)"
-          :width="randint(30, 85) + '%'" height="24px" class="mx-auto"
-        />
-        <b-skeleton :width="randint(30, 85) + '%'" height="24px" class="mx-auto mb-auto" />
-      </b-card>
+          <div class="d-flex w-100 mt-auto">
+            <b-skeleton width="30px" height="30px" class="mr-2 ml-auto" />
+            <b-skeleton :width="randint(30, 70) + '%'" height="30px" class="mr-auto" />
+          </div>
+          <b-skeleton
+            v-if="randint(0, 1)"
+            :width="randint(30, 85) + '%'" height="24px" class="mx-auto"
+          />
+          <b-skeleton :width="randint(30, 85) + '%'" height="24px" class="mx-auto mb-auto" />
+        </b-card>
       </b-card-group>
     </template>
   </view-search>
@@ -150,7 +150,6 @@
 <script>
 import { validationMixin } from 'vuelidate'
 
-import api from '@/api'
 import { required, githubLink } from '@/helpers/validators'
 import { randint } from '@/helpers/commons'
 
diff --git a/app/src/views/backup/BackupList.vue b/app/src/views/backup/BackupList.vue
index 83dfc3a7..d0750b4d 100644
--- a/app/src/views/backup/BackupList.vue
+++ b/app/src/views/backup/BackupList.vue
@@ -52,10 +52,14 @@ export default {
   methods: {
     formatBackupList (data) {
       const archives = Object.entries(data.archives)
-      this.archives = archives.length === 0 ? null : archives.map(([name, infos]) => {
-        infos.name = name
-        return infos
-      }).reverse()
+      if (archives.length) {
+        this.archives = archives.map(([name, infos]) => {
+          infos.name = name
+          return infos
+        }).reverse()
+      } else {
+        this.archives = null
+      }
     }
   },
 
diff --git a/app/src/views/diagnosis/Diagnosis.vue b/app/src/views/diagnosis/Diagnosis.vue
index 25969a8f..e3e9acca 100644
--- a/app/src/views/diagnosis/Diagnosis.vue
+++ b/app/src/views/diagnosis/Diagnosis.vue
@@ -161,7 +161,7 @@ export default {
         report.errors = 0
         report.ignoreds = 0
 
-        for (var item of report.items) {
+        for (const item of report.items) {
           this.formatReportItem(report, item)
         }
         report.noIssues = report.warnings + report.errors === 0