From ad656b925f32941b9d0ec3c3903de46b13a912cb Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Tue, 15 Nov 2022 12:40:15 +0100
Subject: [PATCH] AppInstall: display warning/danger depending on potential
 several problems

---
 app/src/i18n/locales/en.json     |  16 +++++
 app/src/views/app/AppInstall.vue | 105 +++++++++++++++++++++++++++++--
 2 files changed, 117 insertions(+), 4 deletions(-)

diff --git a/app/src/i18n/locales/en.json b/app/src/i18n/locales/en.json
index e940ab97..43c49f1d 100644
--- a/app/src/i18n/locales/en.json
+++ b/app/src/i18n/locales/en.json
@@ -57,6 +57,22 @@
     "app": {
       "antifeatures": "Antifeatures:",
       "install": {
+        "before_install": {
+          "warning": "Things to know before installation",
+          "danger": "The installation of the application will most likely lead to issues",
+          "critical": "The application cannot be installed"
+        },
+        "problems": {
+          "arch": "It is incompatible with your system architecture",
+          "broken": "This application is broken according to YunoHost's automatic tests and it is likely to break your system! You should probably NOT install it unless you know what you are doing.",
+          "thirdparty": "This application is not part of the official YunoHost catalog, installing 3rd party applications may compromise the integrity and security of your system. You should probably NOT install it unless you know what you are doing.",
+          "ignore": "I understand that this installation may break my system but i still want to try.",
+          "inprogress": "This application is still experimental (if not explicitly not working) and it is likely to break your system! You should probably NOT install it unless you know what you are doing.",
+          "install": "It is already installed and can't be installed more than once.",
+          "lowquality": "This application may work but is not well-integrated in YunoHost. Some features such as single sign-on and backup/restore might not be available, or it does not respect the good practices.",
+          "ram": "This application requires {required} of RAM to install/upgrade but only {current} is available right now. Even if this app could run, its installation process requires a large amount of RAM so your server may freeze and fail miserably.",
+          "version": "It is not compatible with your current YunoHost version, consider first upgrading YunoHost."
+        },
         "try_demo": "Try the demo",
         "version": "Current version: {version}"
       },
diff --git a/app/src/views/app/AppInstall.vue b/app/src/views/app/AppInstall.vue
index bcbb03d3..1b85d948 100644
--- a/app/src/views/app/AppInstall.vue
+++ b/app/src/views/app/AppInstall.vue
@@ -58,8 +58,60 @@
         </card-collapse>
       </card>
 
+      <yuno-alert v-if="app.hasWarning" variant="warning" class="my-4">
+        <h2>{{ $t('app.install.before_install.warning') }}</h2>
+
+        <template v-if="app.antifeatures">
+          <strong v-t="'app.antifeatures'" class="d-block mb-1" />
+          <ul class="antifeatures">
+            <li v-for="antifeature in app.antifeatures" :key="antifeature.id">
+              <icon :iname="antifeature.icon" class="md mr-1" />
+              {{ antifeature.title }}
+              <explain-what
+                :id="antifeature.id"
+                :title="antifeature.title"
+                :content="antifeature.description"
+              />
+            </li>
+          </ul>
+        </template>
+
+        <p v-if="app.quality.state === 'lowquality'" v-t="'app.install.problems.lowquality'" />
+
+        <vue-showdown v-if="app.preInstall" :markdown="app.preInstall" flavor="github" />
+      </yuno-alert>
+
+      <yuno-alert
+        v-if="!app.hasSupport"
+        variant="danger" icon="warning" class="my-4"
+      >
+        <h2>{{ $t('app.install.before_install.critical') }}</h2>
+
+        <p v-if="!app.requirements.arch">
+          {{ $t('app.install.problems.arch') }}
+        </p>
+        <p v-else-if="!app.requirements.install">
+          {{ $t('app.install.problems.install') }}
+        </p>
+        <p v-else-if="!app.requirements.version">
+          {{ $t('app.install.problems.version') }}
+        </p>
+      </yuno-alert>
+
+      <yuno-alert v-else-if="app.hasDanger" variant="danger" class="my-4">
+        <h2>{{ $t('app.install.before_install.danger') }}</h2>
+
+        <p v-if="['inprogress', 'broken', 'thirdparty'].includes(app.quality.state)" v-t="'app.install.problems.' + app.quality.state" />
+        <p v-if="!app.requirements.ram.pass">
+          {{ $t('app.install.problems.ram', app.requirements.ram.values) }}
+        </p>
+
+        <checkbox-item v-model="force" id="force-install" :label="$t('app.install.problems.ignore')" />
+      </yuno-alert>
+
       <!-- INSTALL FORM -->
       <card-form
+        v-if="app.canInstall || force"
         :title="$t('app_install_parameters')" icon="cog" :submit-text="$t('install')"
         :validation="$v" :server-error="serverError"
         @submit.prevent="performInstall"
@@ -112,6 +164,7 @@ export default {
   data () {
     return {
       queries: [
+        ['GET', 'apps/catalog?full&with_categories&with_antifeatures'],
         ['GET', 'apps/manifest?app=' + this.id]
       ],
       app: undefined,
@@ -120,7 +173,8 @@ export default {
       fields: undefined,
       validations: null,
       errors: undefined,
-      serverError: ''
+      serverError: '',
+      force: false
     }
   },
 
@@ -129,10 +183,35 @@ export default {
   },
 
   methods: {
-    onQueriesResponse (_app) {
-      const { id, name, version } = _app
+    onQueriesResponse (catalog, _app) {
+      const antifeaturesList = Object.fromEntries(catalog.antifeatures.map((af) => ([af.id, af])))
+
+      const { id, name, version, requirements } = _app
       const _archs = _app.integration.architectures
 
+      const quality = { state: _app.quality.state, variant: 'danger' }
+      if (quality.state === 'working') {
+        if (_app.quality.level <= 0) {
+          quality.state = 'broken'
+        } else if (_app.quality.level <= 4) {
+          quality.state = 'lowquality'
+          quality.variant = 'warning'
+        } else {
+          quality.variant = 'success'
+          quality.state = _app.quality.level >= 8 ? 'highquality' : 'goodquality'
+        }
+      }
+      const preInstall = formatI18nField(_app.notifications.pre_install.main)
+      const antifeatures = _app.antifeatures?.length
+        ? _app.antifeatures.map((af) => antifeaturesList[af])
+        : null
+
+      const hasDanger = quality.variant === 'danger' || !requirements.ram.pass
+      const hasSupport = Object.keys(requirements).every((key) => {
+        // ram support is non-blocking requirement and handled on its own.
+        return key === 'ram' || requirements[key].pass
+      })
+
       const app = {
         id,
         name,
@@ -154,7 +233,15 @@ export default {
           ...['website', 'admindoc', 'code'].map((key) => ([key, _app.upstream[key]])),
           ['package', _app.remote.url],
           ['forum', `https://forum.yunohost.org/tag/${id}`]
-        ].filter(([key, val]) => !!val)
+        ].filter(([key, val]) => !!val),
+        preInstall,
+        antifeatures,
+        quality,
+        requirements,
+        hasWarning: !!preInstall || antifeatures || quality.variant === 'warning',
+        hasDanger,
+        hasSupport,
+        canInstall: hasSupport && !hasDanger
       }
 
       // FIXME yunohost should add the label field by default
@@ -205,3 +292,13 @@ export default {
   }
 }
 </script>
+
+<style lang="scss" scoped>
+.antifeatures {
+  padding-left: 1rem;
+
+  li {
+    list-style: none;
+  }
+}
+</style>