From b9cf8b92fe082edd5c021f405b706d8d4c294d02 Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Fri, 5 Jul 2024 20:52:03 +0200
Subject: [PATCH] refactor: ReadOnlyAlertItem typing

---
 .../globals/formItems/ReadOnlyAlertItem.vue   | 20 ++++++++++---------
 app/src/types/form.ts                         |  4 ++++
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/app/src/components/globals/formItems/ReadOnlyAlertItem.vue b/app/src/components/globals/formItems/ReadOnlyAlertItem.vue
index ff975508..8f90149e 100644
--- a/app/src/components/globals/formItems/ReadOnlyAlertItem.vue
+++ b/app/src/components/globals/formItems/ReadOnlyAlertItem.vue
@@ -1,12 +1,13 @@
 <script setup lang="ts">
 import { computed } from 'vue'
 
-const props = defineProps<{
-  label: string
-  id?: string
-  type?: 'success' | 'info' | 'warning' | 'danger'
-  icon?: string
-}>()
+import type { ReadOnlyAlertItemProps } from '@/types/form'
+
+const props = withDefaults(defineProps<ReadOnlyAlertItemProps>(), {
+  id: undefined,
+  icon: undefined,
+  type: 'success',
+})
 
 const icon = computed(() => {
   const icons = {
@@ -22,11 +23,12 @@ const icon = computed(() => {
 
 <template>
   <BAlert
-    class="d-flex flex-column flex-md-row align-items-center"
+    :id="id"
+    :model-value="true"
     :variant="type"
-    :modelValue="true"
+    class="d-flex flex-column flex-md-row align-items-center"
   >
-    <YIcon :iname="icon" class="me-md-3 mb-md-0 mb-2" :variant="type" />
+    <YIcon :iname="icon" :variant="type" class="me-md-3 mb-md-0 mb-2" />
 
     <VueShowdown :markdown="label" tag="span" class="markdown" />
   </BAlert>
diff --git a/app/src/types/form.ts b/app/src/types/form.ts
index 57b14a85..b82a34d1 100644
--- a/app/src/types/form.ts
+++ b/app/src/types/form.ts
@@ -19,6 +19,10 @@ export type DisplayTextItemProps = BaseDisplayItemProps
 
 export type MarkdownItemProps = BaseDisplayItemProps
 
+export type ReadOnlyAlertItemProps = BaseDisplayItemProps & {
+  icon?: string
+  type?: StateVariant
+}
 
 // WRITABLE