From dc530e36a1fb8dfb1cf7aefea93f57ebd9e5a13c Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Tue, 19 Mar 2024 03:29:26 +0100
Subject: [PATCH] migration(bvn): BAlert needs explicit show value

---
 app/src/components/globals/AbstractForm.vue            |  7 ++++++-
 app/src/components/globals/CardForm.vue                |  2 +-
 app/src/components/globals/ViewSearch.vue              |  6 +++++-
 app/src/components/globals/YAlert.vue                  |  1 +
 .../components/globals/formItems/ReadOnlyAlertItem.vue |  2 +-
 app/src/views/_partials/ErrorDisplay.vue               |  2 +-
 app/src/views/_partials/ReconnectingDisplay.vue        | 10 +++++++---
 app/src/views/app/AppInstall.vue                       |  2 +-
 app/src/views/backup/BackupList.vue                    |  2 +-
 9 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/app/src/components/globals/AbstractForm.vue b/app/src/components/globals/AbstractForm.vue
index ed7581b5..10934e69 100644
--- a/app/src/components/globals/AbstractForm.vue
+++ b/app/src/components/globals/AbstractForm.vue
@@ -13,7 +13,12 @@
         <slot name="default" />
 
         <slot name="server-error" v-bind="{ errorFeedback }">
-          <BAlert v-if="errorFeedback" variant="danger" class="my-3" icon="ban">
+          <BAlert
+            :modelValue="!!errorFeedback"
+            variant="danger"
+            class="my-3"
+            icon="ban"
+          >
             <div v-html="errorFeedback" />
           </BAlert>
         </slot>
diff --git a/app/src/components/globals/CardForm.vue b/app/src/components/globals/CardForm.vue
index 7ab7cb82..7c712887 100644
--- a/app/src/components/globals/CardForm.vue
+++ b/app/src/components/globals/CardForm.vue
@@ -17,7 +17,7 @@
             variant="danger"
             class="my-3"
             icon="ban"
-            :show="errorFeedback !== ''"
+            :modelValue="errorFeedback !== ''"
           >
             <div v-html="errorFeedback" />
           </BAlert>
diff --git a/app/src/components/globals/ViewSearch.vue b/app/src/components/globals/ViewSearch.vue
index f808cbbe..8a1a7cc4 100644
--- a/app/src/components/globals/ViewSearch.vue
+++ b/app/src/components/globals/ViewSearch.vue
@@ -29,7 +29,11 @@
     </template>
 
     <template #default>
-      <BAlert v-if="items === null || filteredItems === null" variant="warning">
+      <BAlert
+        v-if="items === null || filteredItems === null"
+        :modelValue="true"
+        variant="warning"
+      >
         <slot name="alert-message">
           <YIcon iname="exclamation-triangle" />
           {{
diff --git a/app/src/components/globals/YAlert.vue b/app/src/components/globals/YAlert.vue
index 2032c42a..7456636e 100644
--- a/app/src/components/globals/YAlert.vue
+++ b/app/src/components/globals/YAlert.vue
@@ -2,6 +2,7 @@
   <Component
     v-bind="$attrs"
     :is="alert ? 'BAlert' : 'div'"
+    :modelValue="alert ? true : null"
     :variant="alert ? variant : null"
     :class="{ ['alert alert-' + variant]: !alert }"
     class="yuno-alert d-flex flex-column flex-md-row align-items-center"
diff --git a/app/src/components/globals/formItems/ReadOnlyAlertItem.vue b/app/src/components/globals/formItems/ReadOnlyAlertItem.vue
index 851bfafb..9e16dd86 100644
--- a/app/src/components/globals/formItems/ReadOnlyAlertItem.vue
+++ b/app/src/components/globals/formItems/ReadOnlyAlertItem.vue
@@ -2,7 +2,7 @@
   <BAlert
     class="d-flex flex-column flex-md-row align-items-center"
     :variant="type"
-    show
+    :modelValue="true"
   >
     <YIcon :iname="icon_" class="me-md-3 mb-md-0 mb-2" :variant="type" />
 
diff --git a/app/src/views/_partials/ErrorDisplay.vue b/app/src/views/_partials/ErrorDisplay.vue
index fd11eea0..997096ec 100644
--- a/app/src/views/_partials/ErrorDisplay.vue
+++ b/app/src/views/_partials/ErrorDisplay.vue
@@ -23,7 +23,7 @@
 
       <p>
         <strong v-t="'api_error.error_message'" />
-        <BAlert class="mt-2" variant="danger">
+        <BAlert :modelValue="true" class="mt-2" variant="danger">
           <div v-html="error.message" />
         </BAlert>
       </p>
diff --git a/app/src/views/_partials/ReconnectingDisplay.vue b/app/src/views/_partials/ReconnectingDisplay.vue
index be8094c6..25ea9711 100644
--- a/app/src/views/_partials/ReconnectingDisplay.vue
+++ b/app/src/views/_partials/ReconnectingDisplay.vue
@@ -7,14 +7,14 @@
       <YSpinner class="mb-4" />
 
       <BAlert
-        v-if="origin"
+        :modelValue="!!origin"
         v-t="'api.reconnecting.reason.' + origin"
         :variant="origin === 'unknow' ? 'warning' : 'info'"
       />
     </template>
 
     <template v-if="status === 'failed'">
-      <BAlert variant="danger">
+      <BAlert :modelValue="true" variant="danger">
         <MarkdownItem :label="$t('api.reconnecting.failed')" />
       </BAlert>
 
@@ -29,7 +29,11 @@
     </template>
 
     <template v-if="status === 'expired'">
-      <BAlert variant="success" v-t="'api.reconnecting.session_expired'" />
+      <BAlert
+        :modelValue="true"
+        variant="success"
+        v-t="'api.reconnecting.session_expired'"
+      />
 
       <LoginView force-reload />
     </template>
diff --git a/app/src/views/app/AppInstall.vue b/app/src/views/app/AppInstall.vue
index 4b8d9a97..965d758c 100644
--- a/app/src/views/app/AppInstall.vue
+++ b/app/src/views/app/AppInstall.vue
@@ -193,7 +193,7 @@
     </template>
 
     <!-- In case of a custom url with no manifest found -->
-    <BAlert v-else-if="app === null" variant="warning">
+    <BAlert :modelValue="app === null" variant="warning">
       <YIcon iname="exclamation-triangle" />
       {{ $t('app_install_custom_no_manifest') }}
     </BAlert>
diff --git a/app/src/views/backup/BackupList.vue b/app/src/views/backup/BackupList.vue
index 4a58bae4..a1a19f45 100644
--- a/app/src/views/backup/BackupList.vue
+++ b/app/src/views/backup/BackupList.vue
@@ -14,7 +14,7 @@
       />
     </template>
 
-    <BAlert v-if="!archives" variant="warning">
+    <BAlert v-if="!archives" :modelValue="!archives" variant="warning">
       <YIcon iname="exclamation-triangle" />
       {{ $t('items_verbose_count', { items: $t('items.backups', 0) }, 0) }}
     </BAlert>